Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751680AbbHTGu5 (ORCPT ); Thu, 20 Aug 2015 02:50:57 -0400 Received: from mail-bn1on0136.outbound.protection.outlook.com ([157.56.110.136]:65445 "EHLO na01-bn1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751087AbbHTGuz convert rfc822-to-8bit (ORCPT ); Thu, 20 Aug 2015 02:50:55 -0400 From: Duan Andy To: Sanchayan Maity , "jic23@kernel.org" , "linux-iio@vger.kernel.org" CC: "stefan@agner.ch" , "pmeerw@pmeerw.net" , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" Subject: RE: [PATCH v4] iio: adc: vf610: Add IIO buffer support for Vybrid ADC Thread-Topic: [PATCH v4] iio: adc: vf610: Add IIO buffer support for Vybrid ADC Thread-Index: AQHQ2QUTIwfsP/3Ptk2g9lmSJ4P6954Udn1w Date: Thu, 20 Aug 2015 06:50:53 +0000 Message-ID: References: <9be567ec7d6f6370dd42a41438d64cf7aaa47635.1439826018.git.maitysanchayan@gmail.com> In-Reply-To: <9be567ec7d6f6370dd42a41438d64cf7aaa47635.1439826018.git.maitysanchayan@gmail.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=fugang.duan@freescale.com; x-originating-ip: [192.158.241.86] x-microsoft-exchange-diagnostics: 1;BN3PR0301MB1220;5:kzXiqxEL7J7O96/tyTTG79tp9+4kmd3rjmcJmdCKrz41J9bGSW8yCSDAqct3ln0SHPDzhMUlfxvl8pdTAKMkrtfj0LKjfP0ghBrB2f6HXBocMCPokMu7RG5TRV26FizEbsQwoq44Pfdo4RpPs9CrIg==;24:vhAfA/A54GeMGOCVy/kN0ssOAR37IdBb2AxkmaA2m68AZVRL7oTzAwGziIJkAscgax55tIklWmUlNKS+z33e0uAO/O9l/W/RCQGCbwdpjlU=;20:1DRcfneMzQ4cSy3IHy1MTbMdppkJEg/VdKNXuxfrnCxsWkWyGOAyx042QMjCzAyGSfvU6VHGmJTYRi135toc3Q== x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BN3PR0301MB1220; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(601004)(5005006)(8121501046)(3002001);SRVR:BN3PR0301MB1220;BCL:0;PCL:0;RULEID:;SRVR:BN3PR0301MB1220; x-forefront-prvs: 0674DC6DD3 x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(6009001)(189002)(377454003)(199003)(2501003)(99286002)(106356001)(106116001)(105586002)(5002640100001)(87936001)(2201001)(86362001)(5003600100002)(76176999)(101416001)(50986999)(5007970100001)(54356999)(19580395003)(19580405001)(68736005)(2950100001)(2656002)(2900100001)(77096005)(102836002)(33656002)(40100003)(62966003)(77156002)(74316001)(189998001)(10400500002)(46102003)(122556002)(92566002)(5001960100002)(5001920100001)(5001860100001)(4001540100001)(5001830100001)(97736004)(5001770100001)(81156007)(64706001)(66066001)(76576001);DIR:OUT;SFP:1102;SCL:1;SRVR:BN3PR0301MB1220;H:BN3PR0301MB1219.namprd03.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; spamdiagnosticoutput: 1:23 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 X-OriginatorOrg: freescale.com X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Aug 2015 06:50:53.5101 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 710a03f5-10f6-4d38-9ff4-a80b81da590d X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN3PR0301MB1220 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1902 Lines: 44 From: Sanchayan Maity Sent: Monday, August 17, 2015 11:52 PM > To: jic23@kernel.org; linux-iio@vger.kernel.org > Cc: stefan@agner.ch; Duan Fugang-B38611; pmeerw@pmeerw.net; linux- > kernel@vger.kernel.org; linux-arm-kernel@lists.infradead.org; Sanchayan > Maity > Subject: [PATCH v4] iio: adc: vf610: Add IIO buffer support for Vybrid > ADC > > This patch adds support for IIO buffer to the Vybrid ADC driver. > IIO triggered buffer infrastructure along with iio sysfs trigger is used > to leverage continuous sampling support provided by the ADC block. > > Signed-off-by: Sanchayan Maity > --- > > Changes since v3: > Fix iio_buffer_setup_ops for postenable and predisable functions to match > pairwise. Before this the predisable work was being done in postdisable. > > Changes since v2: > 1. Fix the wrong buffer size for statically allocated buffer 2. Drop the > use of .address field from the iio_chan_spec 3. Use iio_buffer_enabled > call inside the lock 4. Drop wrapper function around iio_trigered_* > function calls 5. Drop Kconfig select of sysfs trigger 6. Drop Kconfig > select IIO_TRIGGER as it is already selected by IIO_TRIGGERED_BUFFER > > Changes since v1: > 1. Use a fixed size buffer instead of kmalloc allocated during update > scan mode 2. Remove a write to read only register ADC_HS (COCO bit) > > drivers/iio/adc/Kconfig | 2 + > drivers/iio/adc/vf610_adc.c | 105 > +++++++++++++++++++++++++++++++++++++++++--- > 2 files changed, 100 insertions(+), 7 deletions(-) > The version is fine for me. Thanks for your effort. Acked-by: Fugang Duan -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/