Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751942AbbHTG6j (ORCPT ); Thu, 20 Aug 2015 02:58:39 -0400 Received: from mail-io0-f172.google.com ([209.85.223.172]:35891 "EHLO mail-io0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751090AbbHTG6h (ORCPT ); Thu, 20 Aug 2015 02:58:37 -0400 MIME-Version: 1.0 In-Reply-To: <1440020889-12120-6-git-send-email-paul.gortmaker@windriver.com> References: <1440020889-12120-1-git-send-email-paul.gortmaker@windriver.com> <1440020889-12120-6-git-send-email-paul.gortmaker@windriver.com> Date: Thu, 20 Aug 2015 08:58:37 +0200 Message-ID: Subject: Re: [PATCH 5/5] drivers/tty: make serial 8250_lpc18xx.c Kconfig a tristate From: Joachim Eastwood To: Paul Gortmaker Cc: "linux-kernel@vger.kernel.org" , Greg Kroah-Hartman , Jiri Slaby , linux-serial@vger.kernel.org, "linux-arm-kernel@lists.infradead.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1335 Lines: 36 On 19 August 2015 at 23:48, Paul Gortmaker wrote: > The Kconfig currently controlling compilation of this code is: > > 8250/Kconfig:config SERIAL_8250_LPC18XX > 8250/Kconfig: bool "NXP LPC18xx/43xx serial port support" > > ...meaning that it currently is not being built as a module by anyone. > > When targetting orphaned modular code in non-modular drivers, this > came up. Joachim indicated that the driver was actually meant to > be tristate but ended up bool by accident. So here we make it > tristate instead of removing the modular code that was essentially > orphaned. > > Suggested-by: Joachim Eastwood > Cc: Greg Kroah-Hartman > Cc: Jiri Slaby > Cc: Joachim Eastwood > Cc: linux-serial@vger.kernel.org > Cc: linux-arm-kernel@lists.infradead.org > Signed-off-by: Paul Gortmaker Acked-by: Joachim Eastwood Build tested as a module on lpc18xx. Thanks for fixing it Paul. regards, Joachim Eastwood -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/