Date: Thu, 20 Aug 2015 10:35:29 +0300
From: Dan Carpenter <dan.carpenter@oracle.com>
To: "J. German Rivera" <German.Rivera@freescale.com>
Cc: gregkh@linuxfoundation.org, arnd@arndb.de, devel@driverdev.osuosl.org,
        linux-kernel@vger.kernel.org, stuart.yoder@freescale.com,
        itai.katz@freescale.com, scottwood@freescale.com, agraf@suse.de,
        bhamciu1@freescale.com, R89243@freescale.com,
        bhupesh.sharma@freescale.com, nir.erez@freescale.com,
        richard.schmitt@freescale.com
Subject: Re: [PATCH] staging: fsl-mc: Upgraded MC flibs used in MC bus driver
Message-ID: <20150820073528.GN5610@mwanda>
References: <1440003160-28717-1-git-send-email-German.Rivera@freescale.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1440003160-28717-1-git-send-email-German.Rivera@freescale.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 983
Lines: 26

On Wed, Aug 19, 2015 at 11:52:40AM -0500, J. German Rivera wrote:
> Since signatures of flib functions have changed, we had to
> change all the corresponding calls in the MC bus driver
> 

What does upgrade mean here?  I feel like this is the kind of patch we
reject without reading the patch because the description is too vague
and you can tell from the diff stats that it is going to be too huge to
review.

I looked at the first few lines and we are making a ball of changes.
Copyright notices, adding function parameters, renaming functions.  This
needs to be explained a lot better and probably split into multiple
patches.

Btw, the trees are closed for the next 3-4 weeks until after 4.3-rc2 is
released.

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/