Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752034AbbHTHtL (ORCPT ); Thu, 20 Aug 2015 03:49:11 -0400 Received: from mail-pa0-f51.google.com ([209.85.220.51]:35428 "EHLO mail-pa0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751633AbbHTHtI convert rfc822-to-8bit (ORCPT ); Thu, 20 Aug 2015 03:49:08 -0400 References: <1439995728-18046-1-git-send-email-ykk@rock-chips.com> <1439995939-18770-1-git-send-email-ykk@rock-chips.com> Mime-Version: 1.0 (1.0) In-Reply-To: <1439995939-18770-1-git-send-email-ykk@rock-chips.com> Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 8BIT Message-Id: <6E5CEF9B-19D4-4AC4-B5B1-BC667979302D@gmail.com> Cc: Heiko Stuebner , Thierry Reding , Fabio Estevam , Inki Dae , "joe@perches.com" , Russell King , "djkurtz@google.com" , "dianders@google.com" , "seanpaul@google.com" , Takashi Iwai , "ajaynumb@gmail.com" , Andrzej Hajda , Kyungmin Park , Philipp Zabel , David Airlie , Gustavo Padovan , Vincent Palatin , Mark Yao , Andy Yan , Kumar Gala , Ian Campbell , Rob Herring , Pawel Moll , Kishon Vijay Abraham I , "dri-devel@lists.freedesktop.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-samsung-soc@vger.kernel.org" , "linux-rockchip@lists.infradead.org" , "linux-arm-kernel@lists.infradead.org" , jingoohan1@gmail.com X-Mailer: iPhone Mail (11D257) From: Jingoo Han Subject: Re: [PATCH v3 13/14] drm: bridge/analogix_dp: move hpd detect to connector detect function Date: Thu, 20 Aug 2015 16:49:00 +0900 To: Yakir Yang Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1839 Lines: 60 On 2015. 8. 19., at PM 11:52, Yakir Yang wrote: > What is the reason to make this patch? Please make commit message including the reason. Best regards, Jingoo Han > Signed-off-by: Yakir Yang > --- > Changes in v3: > - move dp hpd detect to connector detect function. > > Changes in v2: None > > drivers/gpu/drm/bridge/analogix_dp_core.c | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/drivers/gpu/drm/bridge/analogix_dp_core.c b/drivers/gpu/drm/bridge/analogix_dp_core.c > index 75dd44a..052b9b3 100644 > --- a/drivers/gpu/drm/bridge/analogix_dp_core.c > +++ b/drivers/gpu/drm/bridge/analogix_dp_core.c > @@ -915,12 +915,6 @@ static void analogix_dp_commit(struct analogix_dp_device *dp) > DRM_ERROR("failed to disable the panel\n"); > } > > - ret = analogix_dp_detect_hpd(dp); > - if (ret) { > - /* Cable has been disconnected, we're done */ > - return; > - } > - > ret = analogix_dp_handle_edid(dp); > if (ret) { > dev_err(dp->dev, "unable to handle edid\n"); > @@ -953,6 +947,12 @@ static void analogix_dp_commit(struct analogix_dp_device *dp) > static enum drm_connector_status analogix_dp_detect( > struct drm_connector *connector, bool force) > { > + struct analogix_dp_device *dp = connector_to_dp(connector); > + > + if (analogix_dp_detect_hpd(dp)) > + /* Cable has been disconnected, we're done */ > + return connector_status_disconnected; > + > return connector_status_connected; > } > > -- > 1.9.1 > > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/