Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752793AbbHTISz (ORCPT ); Thu, 20 Aug 2015 04:18:55 -0400 Received: from regular1.263xmail.com ([211.150.99.137]:33560 "EHLO regular1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751602AbbHTISv (ORCPT ); Thu, 20 Aug 2015 04:18:51 -0400 X-263anti-spam: KSV:0; X-MAIL-GRAY: 0 X-MAIL-DELIVERY: 1 X-KSVirus-check: 0 X-ABS-CHECKED: 4 X-ADDR-CHECKED: 0 X-RL-SENDER: ykk@rock-chips.com X-FST-TO: linux-arm-kernel@lists.infradead.org X-SENDER-IP: 191.101.57.25 X-LOGIN-NAME: ykk@rock-chips.com X-UNIQUE-TAG: <33ac6b7086a70634e8b77cee817dd8c2> X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 Message-ID: <55D58D56.5070505@rock-chips.com> Date: Thu, 20 Aug 2015 03:18:30 -0500 From: Yakir Yang User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: Jingoo Han CC: Heiko Stuebner , Thierry Reding , Fabio Estevam , Inki Dae , "joe@perches.com" , Russell King , "djkurtz@google.com" , "dianders@google.com" , "seanpaul@google.com" , Takashi Iwai , "ajaynumb@gmail.com" , Andrzej Hajda , Kyungmin Park , Philipp Zabel , David Airlie , Gustavo Padovan , Vincent Palatin , Mark Yao , Andy Yan , Kumar Gala , Ian Campbell , Rob Herring , Pawel Moll , Kishon Vijay Abraham I , "dri-devel@lists.freedesktop.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-samsung-soc@vger.kernel.org" , "linux-rockchip@lists.infradead.org" , "linux-arm-kernel@lists.infradead.org" Subject: Re: [PATCH v3 13/14] drm: bridge/analogix_dp: move hpd detect to connector detect function References: <1439995728-18046-1-git-send-email-ykk@rock-chips.com> <1439995939-18770-1-git-send-email-ykk@rock-chips.com> <6E5CEF9B-19D4-4AC4-B5B1-BC667979302D@gmail.com> In-Reply-To: <6E5CEF9B-19D4-4AC4-B5B1-BC667979302D@gmail.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2182 Lines: 74 Hi Jingoo, On 08/20/2015 02:49 AM, Jingoo Han wrote: > On 2015. 8. 19., at PM 11:52, Yakir Yang wrote: > > What is the reason to make this patch? > > Please make commit message including the reason. Okay, I think the below words would be okay :) "This change just make a little clean to make code more like drm core expect, move hdp detect code from bridge->enable(), and place them into connector->detect()." Thanks, - Yakir > Best regards, > Jingoo Han > >> Signed-off-by: Yakir Yang >> --- >> Changes in v3: >> - move dp hpd detect to connector detect function. >> >> Changes in v2: None >> >> drivers/gpu/drm/bridge/analogix_dp_core.c | 12 ++++++------ >> 1 file changed, 6 insertions(+), 6 deletions(-) >> >> diff --git a/drivers/gpu/drm/bridge/analogix_dp_core.c b/drivers/gpu/drm/bridge/analogix_dp_core.c >> index 75dd44a..052b9b3 100644 >> --- a/drivers/gpu/drm/bridge/analogix_dp_core.c >> +++ b/drivers/gpu/drm/bridge/analogix_dp_core.c >> @@ -915,12 +915,6 @@ static void analogix_dp_commit(struct analogix_dp_device *dp) >> DRM_ERROR("failed to disable the panel\n"); >> } >> >> - ret = analogix_dp_detect_hpd(dp); >> - if (ret) { >> - /* Cable has been disconnected, we're done */ >> - return; >> - } >> - >> ret = analogix_dp_handle_edid(dp); >> if (ret) { >> dev_err(dp->dev, "unable to handle edid\n"); >> @@ -953,6 +947,12 @@ static void analogix_dp_commit(struct analogix_dp_device *dp) >> static enum drm_connector_status analogix_dp_detect( >> struct drm_connector *connector, bool force) >> { >> + struct analogix_dp_device *dp = connector_to_dp(connector); >> + >> + if (analogix_dp_detect_hpd(dp)) >> + /* Cable has been disconnected, we're done */ >> + return connector_status_disconnected; >> + >> return connector_status_connected; >> } >> >> -- >> 1.9.1 >> >> > > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/