Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752260AbbHTJCI (ORCPT ); Thu, 20 Aug 2015 05:02:08 -0400 Received: from mail-out.m-online.net ([212.18.0.10]:58430 "EHLO mail-out.m-online.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751732AbbHTJCB (ORCPT ); Thu, 20 Aug 2015 05:02:01 -0400 X-Auth-Info: mq3RpFdEOKjcKtYQAL/f6DhK0lqcvUUg5gZ79Sy6xiI= From: Marek Vasut To: Viet Nga Dao Subject: Re: [PATCH] [PATCH v5] mtd:spi-nor: Add Altera Quad SPI Driver Date: Thu, 20 Aug 2015 11:01:58 +0200 User-Agent: KMail/1.13.7 (Linux/3.14-2-amd64; KDE/4.13.1; x86_64; ; ) Cc: "linux-mtd@lists.infradead.org" , Brian Norris , David Woodhouse , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "nga_chi86" References: <1440053705-3836-1-git-send-email-vndao@altera.com> In-Reply-To: MIME-Version: 1.0 Content-Type: Text/Plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Message-Id: <201508201101.58702.marex@denx.de> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1554 Lines: 38 On Thursday, August 20, 2015 at 10:17:57 AM, Viet Nga Dao wrote: > Sorry for missing to reply the last question Hi! > >>> diff --git a/drivers/mtd/spi-nor/spi-nor.c > >>> b/drivers/mtd/spi-nor/spi-nor.c index 14a5d23..2ab7279 100644 > >>> --- a/drivers/mtd/spi-nor/spi-nor.c > >>> +++ b/drivers/mtd/spi-nor/spi-nor.c > >>> @@ -687,6 +687,24 @@ static const struct spi_device_id spi_nor_ids[] = > >>> { > >>> > >>> { "cat25c09", CAT25_INFO( 128, 8, 32, 2, SPI_NOR_NO_ERASE | > >>> > >>> SPI_NOR_NO_FR) }, { "cat25c17", CAT25_INFO( 256, 8, 32, 2, > >>> SPI_NOR_NO_ERASE | SPI_NOR_NO_FR) }, { "cat25128", CAT25_INFO(2048, 8, > >>> 64, 2, SPI_NOR_NO_ERASE | SPI_NOR_NO_FR) }, + > >>> + /* Altera EPCQ/EPCS Flashes are non-JEDEC */ > >> > >> Are they really ? Last time I checked on CV SoC, I was able to read > >> their JEDEC ID just fine ; though it's true I used that EPCS core. > > Altera EPCS flash is non-jedec device. And this new controller is not > EPCS controller. If you look at the documentation i sent in another > email, they are not the same. https://www.altera.com/content/dam/altera- www/global/en_US/pdfs/literature/hb/cfg/cfg_cf52012.pdf page 15 ; seems like opcode 0x9f is supported. All the other opcodes seems compatible too. What is the problem ? Best regards, Marek Vasut -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/