Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752469AbbHTJ4U (ORCPT ); Thu, 20 Aug 2015 05:56:20 -0400 Received: from smtp.citrix.com ([66.165.176.89]:16473 "EHLO SMTP.CITRIX.COM" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751955AbbHTJ4R (ORCPT ); Thu, 20 Aug 2015 05:56:17 -0400 X-IronPort-AV: E=Sophos;i="5.15,714,1432598400"; d="scan'208";a="292856434" Message-ID: <55D5A42E.7070800@citrix.com> Date: Thu, 20 Aug 2015 10:55:58 +0100 From: David Vrabel User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.8.0 MIME-Version: 1.0 To: Julien Grall , CC: , , "Greg Kroah-Hartman" , , , David Vrabel , "Boris Ostrovsky" , Jiri Slaby , Subject: Re: [Xen-devel] [PATCH v3 11/20] tty/hvc: xen: Use xen page definition References: <1438966019-19322-1-git-send-email-julien.grall@citrix.com> <1438966019-19322-12-git-send-email-julien.grall@citrix.com> In-Reply-To: <1438966019-19322-12-git-send-email-julien.grall@citrix.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-DLP: MIA1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1078 Lines: 32 On 07/08/15 17:46, Julien Grall wrote: > The console ring is always based on the page granularity of Xen. [...] > --- a/drivers/tty/hvc/hvc_xen.c > +++ b/drivers/tty/hvc/hvc_xen.c > @@ -230,7 +230,7 @@ static int xen_hvm_console_init(void) > if (r < 0 || v == 0) > goto err; > gfn = v; > - info->intf = xen_remap(gfn << PAGE_SHIFT, PAGE_SIZE); > + info->intf = xen_remap(gfn << XEN_PAGE_SHIFT, PAGE_SIZE); You need XEN_PAGE_SIZE here I think... > if (info->intf == NULL) > goto err; > info->vtermno = HVC_COOKIE; > @@ -472,7 +472,7 @@ static int xencons_resume(struct xenbus_device *dev) > struct xencons_info *info = dev_get_drvdata(&dev->dev); > > xencons_disconnect_backend(info); > - memset(info->intf, 0, PAGE_SIZE); > + memset(info->intf, 0, XEN_PAGE_SIZE); ...particularly since you use it here. David -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/