Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751564AbbHTKQS (ORCPT ); Thu, 20 Aug 2015 06:16:18 -0400 Received: from smtp-out4.electric.net ([192.162.216.185]:62724 "EHLO smtp-out4.electric.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751270AbbHTKQR convert rfc822-to-8bit (ORCPT ); Thu, 20 Aug 2015 06:16:17 -0400 From: David Laight To: David Laight , "'linux-kernel@vger.kernel.org'" Subject: RE: Re: [PATCH 4.2-rc5] workqueue: Make flush_workqueue() available again to non GPL modules Thread-Topic: Re: [PATCH 4.2-rc5] workqueue: Make flush_workqueue() available again to non GPL modules Thread-Index: AdDPZHfueAynKxgKQEe2/vA/h3LurwLzCxfQ Date: Thu, 20 Aug 2015 10:13:21 +0000 Message-ID: <063D6719AE5E284EB5DD2968C1650D6D1CB804B6@AcuExch.aculab.com> References: <063D6719AE5E284EB5DD2968C1650D6D1CB735FD@AcuExch.aculab.com> In-Reply-To: <063D6719AE5E284EB5DD2968C1650D6D1CB735FD@AcuExch.aculab.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.202.99.200] Content-Type: text/plain; charset="Windows-1252" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 X-Outbound-IP: 213.249.233.130 X-Env-From: David.Laight@ACULAB.COM X-PolicySMART: 3396946, 3397078 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1600 Lines: 40 From: David Laight > Sent: 05 August 2015 10:52 > To: linux-kernel@vger.kernel.org > Subject: Re: [PATCH 4.2-rc5] workqueue: Make flush_workqueue() available again to non GPL modules > > > From: Tejun Heo > > Date: 2015-08-04 18:05:20 > > On Tue, Aug 04, 2015 at 11:26:04AM -0600, tim.gardner@canonical.com wrote: > > > From: Tim Gardner > > > > > > Commit 37b1ef31a568fc02e53587620226e5f3c66454c8 ("workqueue: move > > > flush_scheduled_work() to workqueue.h") moved the exported non GPL > > > flush_scheduled_work() from a function to an inline wrapper. > > > Unfortunately, it directly calls flush_workqueue() which is a GPL function. > > > This has the effect of changing the licensing requirement for this function > > > and makes it unavailable to non GPL modules. > > > > > > See commit ad7b1f841f8a54c6d61ff181451f55b68175e15a ("workqueue: Make > > > schedule_work() available again to non GPL modules") for precedent. > > > > > > Cc: Tejun Heo > > > Signed-off-by: Tim Gardner > > > > Applied to wq/for-4.3. > > I hit this yesterday afternoon as well! > > Can we get the fix into 4.2 itself ? This doesn't seem to be in 4.2 yet. It is an interface regression that will cause grief. David (I'm not subscribed to linux-kernel, so copy me in any responses.) -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/