Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751700AbbHTKxp (ORCPT ); Thu, 20 Aug 2015 06:53:45 -0400 Received: from smtp-out6.electric.net ([192.162.217.184]:65164 "EHLO smtp-out6.electric.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750947AbbHTKxn convert rfc822-to-8bit (ORCPT ); Thu, 20 Aug 2015 06:53:43 -0400 From: David Laight To: "'Vaishali Thakkar'" , Felipe Balbi CC: Greg Kroah-Hartman , "linux-usb@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: RE: [PATCH] usb: gadget: f_uac1: Convert use of __constant_cpu_to_le16 to cpu_to_le16 Thread-Topic: [PATCH] usb: gadget: f_uac1: Convert use of __constant_cpu_to_le16 to cpu_to_le16 Thread-Index: AQHQ2j/yD7Ok64YU90KPzAXeYWFpdp4Ut1+w Date: Thu, 20 Aug 2015 10:50:45 +0000 Message-ID: <063D6719AE5E284EB5DD2968C1650D6D1CB804E2@AcuExch.aculab.com> References: <20150819053122.GA11573@localhost> In-Reply-To: <20150819053122.GA11573@localhost> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.202.99.200] Content-Type: text/plain; charset="Windows-1252" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 X-Outbound-IP: 213.249.233.130 X-Env-From: David.Laight@ACULAB.COM X-PolicySMART: 3396946, 3397078 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1885 Lines: 48 From: Vaishali Thakkar > Sent: 19 August 2015 06:31 > To: Felipe Balbi > Cc: Greg Kroah-Hartman; linux-usb@vger.kernel.org; linux-kernel@vger.kernel.org > Subject: [PATCH] usb: gadget: f_uac1: Convert use of __constant_cpu_to_le16 to cpu_to_le16 > > In big endian cases, macro cpu_to_le16 unfolds to __swab16 which > provides special case for constants. In little endian cases, > __constant_cpu_to_le16 and cpu_to_le16 expand directly to the > same expression. So, replace __constant_cpu_to_le16 with > cpu_to_le16 with the goal of getting rid of the definition of > __constant_cpu_to_le16 completely. > > The semantic patch that performs this transformation is as follows: > > @@expression x;@@ > > - __constant_cpu_to_le16(x) > + cpu_to_le16(x) > > Signed-off-by: Vaishali Thakkar > --- > drivers/usb/gadget/function/f_uac1.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/usb/gadget/function/f_uac1.c b/drivers/usb/gadget/function/f_uac1.c > index 7856b33..5aa8d8a 100644 > --- a/drivers/usb/gadget/function/f_uac1.c > +++ b/drivers/usb/gadget/function/f_uac1.c > @@ -57,8 +57,8 @@ static struct uac1_ac_header_descriptor_1 ac_header_desc = { > .bLength = UAC_DT_AC_HEADER_LENGTH, > .bDescriptorType = USB_DT_CS_INTERFACE, > .bDescriptorSubtype = UAC_HEADER, > - .bcdADC = __constant_cpu_to_le16(0x0100), > - .wTotalLength = __constant_cpu_to_le16(UAC_DT_TOTAL_LENGTH), > + .bcdADC = cpu_to_le16(0x0100), > + .wTotalLength = cpu_to_le16(UAC_DT_TOTAL_LENGTH), Have you test compiled this on a big-endian system? My gut feeling is that is fails. David -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/