Date: Thu, 20 Aug 2015 13:18:37 +0200
From: Jiri Olsa <jolsa@redhat.com>
To: Stephane Eranian <eranian@google.com>
Cc: linux-kernel@vger.kernel.org, acme@redhat.com, peterz@infradead.org,
        mingo@elte.hu, ak@linux.intel.com, namhyung@kernel.org,
        kan.liang@intel.com, dsahern@gmail.com, adrian.hunter@intel.com
Subject: Re: [PATCH v1 3/4] perf record: add ability to name registers to
 record
Message-ID: <20150820111837.GE4640@krava.brq.redhat.com>
References: <1439973506-2166-1-git-send-email-eranian@google.com>
 <1439973506-2166-4-git-send-email-eranian@google.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1439973506-2166-4-git-send-email-eranian@google.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1695
Lines: 65

On Wed, Aug 19, 2015 at 10:38:25AM +0200, Stephane Eranian wrote:

SNIP

> diff --git a/tools/perf/util/parse-regs-options.c b/tools/perf/util/parse-regs-options.c
> new file mode 100644
> index 0000000..4f2c1c2
> --- /dev/null
> +++ b/tools/perf/util/parse-regs-options.c
> @@ -0,0 +1,71 @@
> +#include "perf.h"
> +#include "util/util.h"
> +#include "util/debug.h"
> +#include "util/parse-options.h"
> +#include "util/parse-regs-options.h"
> +
> +int
> +parse_regs(const struct option *opt, const char *str, int unset)
> +{
> +	uint64_t *mode = (uint64_t *)opt->value;
> +	const struct sample_reg *r;
> +	char *s, *os = NULL, *p;
> +	int ret = -1;
> +
> +	if (unset)
> +		return 0;
> +
> +	/*
> +	 * cannot set it twice
> +	 */
> +	if (*mode)
> +		return -1;
> +
> +	/* str may be NULL in case no arg is passed to -I */
> +	if (str) {
> +		/* because str is read-only */
> +		s = os = strdup(str);
> +		if (!s)
> +			return -1;
> +
> +		for (;;) {
> +			p = strchr(s, ',');
> +			if (p)
> +				*p = '\0';
> +
> +			if (!strcmp(s, "?")) {
> +				fprintf(stderr, "available registers: ");
> +				for (r = sample_reg_masks; r->name; r++) {
> +					fprintf(stderr, "%s ", r->name);
> +				}
> +				fputc('\n', stderr);
> +				/* just printing available regs */
> +				return -1;
> +			}
> +			for (r = sample_reg_masks; r->name; r++) {

the new 'I' is arch dependent, would this fail to link on
other archs besides x86_64 ?  haven't tried though

jirka
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/