Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752483AbbHTMqM (ORCPT ); Thu, 20 Aug 2015 08:46:12 -0400 Received: from mail-wi0-f178.google.com ([209.85.212.178]:38619 "EHLO mail-wi0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752335AbbHTMqJ (ORCPT ); Thu, 20 Aug 2015 08:46:09 -0400 Date: Thu, 20 Aug 2015 14:46:06 +0200 From: Michal Hocko To: Mel Gorman Cc: Linux-MM , Johannes Weiner , Rik van Riel , Vlastimil Babka , David Rientjes , Joonsoo Kim , LKML Subject: Re: [PATCH 07/10] mm: page_alloc: Rename __GFP_WAIT to __GFP_RECLAIM Message-ID: <20150820124606.GF20110@dhcp22.suse.cz> References: <1439376335-17895-1-git-send-email-mgorman@techsingularity.net> <1439376335-17895-8-git-send-email-mgorman@techsingularity.net> <20150820122857.GC20110@dhcp22.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150820122857.GC20110@dhcp22.suse.cz> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1182 Lines: 27 On Thu 20-08-15 14:28:57, Michal Hocko wrote: > On Wed 12-08-15 11:45:32, Mel Gorman wrote: > > __GFP_WAIT was used to signal that the caller was in atomic context and > > could not sleep. Now it is possible to distinguish between true atomic > > context and callers that are not willing to sleep. The latter should clear > > __GFP_DIRECT_RECLAIM so kswapd will still wake. As clearing __GFP_WAIT > > behaves differently, there is a risk that people will clear the wrong > > flags. This patch renames __GFP_WAIT to __GFP_RECLAIM to clearly indicate > > what it does -- setting it allows all reclaim activity, clearing them > > prevents it. > > > > Signed-off-by: Mel Gorman > > I haven't checked all the converted places too deeply but they look > straightforward. > > Acked-by: Michal Hocko I meant @suse.com, dang the old one is hardwired into my hands... -- Michal Hocko SUSE Labs -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/