Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752741AbbHTNbe (ORCPT ); Thu, 20 Aug 2015 09:31:34 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:54374 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752690AbbHTNbc (ORCPT ); Thu, 20 Aug 2015 09:31:32 -0400 Message-ID: <1684abfb98b709024bf68a9507ba99a2.squirrel@www.codeaurora.org> In-Reply-To: References: <1439720057-9186-1-git-send-email-ygardi@codeaurora.org> <1439720057-9186-9-git-send-email-ygardi@codeaurora.org> Date: Thu, 20 Aug 2015 13:31:30 -0000 Subject: Re: [PATCH v1 8/8] scsi: ufs-qcom: add QUniPro hardware support and power optimizations From: ygardi@codeaurora.org To: "Akinobu Mita" Cc: "Yaniv Gardi" , "Rob Herring" , "Jej B" , "Paul Bolle" , "Christoph Hellwig" , "LKML" , "linux-scsi@vger.kernel.org" , linux-arm-msm@vger.kernel.org, "Santosh Y" , linux-scsi-owner@vger.kernel.org, "Subhash Jadavani" , "Gilad Broner" , "Dolev Raviv" , "Vinayak Holikatti" , "James E.J. Bottomley" User-Agent: SquirrelMail/1.4.22-4.el6 MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7BIT X-Priority: 3 (Normal) Importance: Normal Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1438 Lines: 48 Thank you Mita for the review. Your comments were correct and helpful. I appreciate your time and effort. please see inline. > 2015-08-16 19:14 GMT+09:00 Yaniv Gardi : >> @@ -1208,6 +1510,7 @@ static struct ufs_hba_variant_ops >> ufs_hba_qcom_vops = { >> .resume = ufs_qcom_resume, >> .dbg_register_dump = ufs_qcom_dump_dbg_regs, >> }; >> +EXPORT_SYMBOL(ufs_hba_qcom_vops); > > As I said in the view comment for the patch 5, this shouldn't be exported > again. I removed this export at all. it is not needed anymore. > >> @@ -775,6 +781,12 @@ static inline int ufshcd_vops_resume(struct ufs_hba >> *hba, enum ufs_pm_op op) >> return 0; >> } >> >> +static inline void ufshcd_vops_dbg_register_dump(struct ufs_hba *hba) >> +{ >> + if (hba->vops && hba->vops->dbg_register_dump) >> + hba->vops->dbg_register_dump(hba); >> +} >> + > > This change should be done in the patch 7? you are correct. > -- > To unsubscribe from this list: send the line "unsubscribe linux-scsi" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/