Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752614AbbHTOJ5 (ORCPT ); Thu, 20 Aug 2015 10:09:57 -0400 Received: from iolanthe.rowland.org ([192.131.102.54]:48079 "HELO iolanthe.rowland.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1751584AbbHTOJ4 (ORCPT ); Thu, 20 Aug 2015 10:09:56 -0400 Date: Thu, 20 Aug 2015 10:09:54 -0400 (EDT) From: Alan Stern X-X-Sender: stern@iolanthe.rowland.org To: Ramneek Mehresh cc: "linux-kernel@vger.kernel.org" , "balbi@ti.com" , "gregkh@linuxfoundation.org" , "linux-usb@vger.kernel.org" , Li Leo Subject: RE: [PATCH 3/8][v3]usb:fsl:otg: Add support to add/remove usb host driver In-Reply-To: Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1158 Lines: 32 On Thu, 20 Aug 2015, Ramneek Mehresh wrote: > > > --- a/drivers/usb/host/ehci-fsl.h > > > +++ b/drivers/usb/host/ehci-fsl.h > > > @@ -63,4 +63,22 @@ > > > #define UTMI_PHY_EN (1<<9) > > > #define ULPI_PHY_CLK_SEL (1<<10) > > > #define PHY_CLK_VALID (1<<17) > > > + > > > +struct ehci_fsl { > > > +#ifdef CONFIG_PM > > > + /* Saved USB PHY settings, need to restore after deep sleep. */ > > > + u32 usb_ctrl; > > > +#endif > > > > Do you need this #ifdef? > > > Yes, this is required for deep-sleep support...we need to save/restore controller > registers during deep-sleep when usb controller power is shut-off. Don't need this > during normal usb operation...saving/restoring usb controller registers in non deep-sleep > scenario will add unnecessary delays What I meant was, can you keep the "u32 usb_ctrl;" line but get rid of the "#ifdef CONFIG_PM" and "#endif" lines? Alan Stern -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/