Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752814AbbHTQRL (ORCPT ); Thu, 20 Aug 2015 12:17:11 -0400 Received: from mail-pa0-f46.google.com ([209.85.220.46]:33756 "EHLO mail-pa0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752485AbbHTQRI (ORCPT ); Thu, 20 Aug 2015 12:17:08 -0400 Date: Thu, 20 Aug 2015 21:47:04 +0530 From: Viresh Kumar To: Vaishali Thakkar Cc: Zhang Rui , Eduardo Valentin , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] thermal: cpu_cooling: Remove usage of devm functions Message-ID: <20150820161704.GD4159@linux> References: <20150820161402.GA4951@localhost> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150820161402.GA4951@localhost> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 937 Lines: 24 On 20-08-15, 21:44, Vaishali Thakkar wrote: > In the function cpufreq_get_requested_power, the memory allocated > for load_cpu is live within the function only. And after the > allocation it is immediately freed with devm_kfree. There is no > need to allocate memory for load_cpu with devm function so replace > devm_kcalloc with kcalloc and devm_kfree with kfree. > > Signed-off-by: Vaishali Thakkar > --- > Changes since v1: > - Introduce new label based on Viresh Kumar's suggestion > --- > drivers/thermal/cpu_cooling.c | 20 +++++++++----------- > 1 file changed, 9 insertions(+), 11 deletions(-) Acked-by: Viresh Kumar -- viresh -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/