Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753293AbbHTRXW (ORCPT ); Thu, 20 Aug 2015 13:23:22 -0400 Received: from foss.arm.com ([217.140.101.70]:57085 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751888AbbHTRXU (ORCPT ); Thu, 20 Aug 2015 13:23:20 -0400 Date: Thu, 20 Aug 2015 18:23:08 +0100 From: Mark Rutland To: "dinguyen@opensource.altera.com" Cc: "robh+dt@kernel.org" , "ijc+devicetree@hellion.org.uk" , "galak@codeaurora.org" , Pawel Moll , Catalin Marinas , Will Deacon , "dinh.linux@gmail.com" , "jszhang@marvell.com" , "devicetree@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCHv2] arm64: dts: Add base stratix 10 dtsi Message-ID: <20150820172308.GA2711@svinekod> References: <1439308127-7412-1-git-send-email-dinguyen@opensource.altera.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1439308127-7412-1-git-send-email-dinguyen@opensource.altera.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1119 Lines: 37 Hi, > +/ { > + compatible = "altr,socfpga-stratix10"; > + #address-cells = <1>; > + #size-cells = <1>; I would recommend that you make your root #address-cells and #size-cells equal to 2, as that will simplify matters later if/when you need to add anything beyond the first 4GB for some particular board. If everything in the SoC falls within the first 4GB you can have a ranges property on your /soc node and have only one cell below that. [...] > + intc: intc@ffff8000 { The unit-address doesn't match the first address in the reg entry. > + compatible = "arm,gic-400", "arm,cortex-a15-gic"; > + #interrupt-cells = <3>; > + interrupt-controller; > + reg = <0x0 0xffff9000 0x1000>, > + <0x0 0xffffa000 0x2000>, > + <0x0 0xffffc000 0x1000>, > + <0x0 0xffffd000 0x1000>; > + }; Shouldn't the virtual CPU interface also be 0x2000 long? Mark. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/