Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751754AbbHTRjT (ORCPT ); Thu, 20 Aug 2015 13:39:19 -0400 Received: from mail-la0-f51.google.com ([209.85.215.51]:34817 "EHLO mail-la0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750926AbbHTRjS (ORCPT ); Thu, 20 Aug 2015 13:39:18 -0400 Date: Thu, 20 Aug 2015 23:38:47 +0600 From: Alexander Kuleshov To: Jiri Kosina Cc: Alexander Kuleshov , Henrik Rydberg , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] drivers/hid: Check result of debugfs_create_dir() and debugfs_create_file() Message-ID: <20150820173847.GA1821@localhost> References: <1439922909-18452-1-git-send-email-kuleshovmail@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Operating-System: Linux X-Date: Thu Aug 20 23:25:44 ALMT 2015 User-Agent: Mutt/1.5.23.1 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 808 Lines: 24 Hello Jiri, On 08-19-15, Jiri Kosina wrote: > On Wed, 19 Aug 2015, Alexander Kuleshov wrote: > > > > > - hid_debug_init(); > > + if (hid_debug) > > + hid_debug_init(); > > How is this change related to the rest of the patch? > > It's wrong anyway, because hid_debug is independent of the debugfs HID > debugging facility. Please see for example the printk() a few lines above > in this very function, which is emited in case hid_debug is enabled. > hmm, I thought that these things are related. I've remove all hid_debug check and sent v3 of the patch. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/