Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751739AbbHTSSW (ORCPT ); Thu, 20 Aug 2015 14:18:22 -0400 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:53992 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750986AbbHTSSV (ORCPT ); Thu, 20 Aug 2015 14:18:21 -0400 Date: Thu, 20 Aug 2015 11:17:52 -0700 From: Mark Brown To: Leilk Liu Cc: Mark Rutland , Matthias Brugger , Sascha Hauer , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-spi@vger.kernel.org, linux-mediatek@lists.infradead.org Message-ID: <20150820181752.GH12027@sirena.org.uk> References: <1440062349-25513-1-git-send-email-leilk.liu@mediatek.com> <1440062349-25513-5-git-send-email-leilk.liu@mediatek.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="dDnEQgWzhgf+8aPe" Content-Disposition: inline In-Reply-To: <1440062349-25513-5-git-send-email-leilk.liu@mediatek.com> X-Cookie: You are fairminded, just and loving. User-Agent: Mutt/1.5.23 (2014-03-12) X-SA-Exim-Connect-IP: 69.84.245.29 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH v2 4/4] spi: mediatek: revise coding style X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1827 Lines: 45 --dDnEQgWzhgf+8aPe Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Aug 20, 2015 at 05:19:09PM +0800, Leilk Liu wrote: > This patch revises littery coding style according to comments. I can't understand this commit log, sorry - what are the comments that are being addressed? > - reg_val |= (((high_time - 1) & 0xff) << SPI_CFG0_SCK_HIGH_OFFSET); > - reg_val |= (((low_time - 1) & 0xff) << SPI_CFG0_SCK_LOW_OFFSET); > - reg_val |= (((holdtime - 1) & 0xff) << SPI_CFG0_CS_HOLD_OFFSET); > - reg_val |= (((setuptime - 1) & 0xff) << SPI_CFG0_CS_SETUP_OFFSET); > + reg_val |= (((sck_time - 1) & 0xff) << SPI_CFG0_SCK_HIGH_OFFSET); > + reg_val |= (((sck_time - 1) & 0xff) << SPI_CFG0_SCK_LOW_OFFSET); > + reg_val |= (((cs_time - 1) & 0xff) << SPI_CFG0_CS_HOLD_OFFSET); > + reg_val |= (((cs_time - 1) & 0xff) << SPI_CFG0_CS_SETUP_OFFSET); This isn't a coding style change this is (I think) renaming a bunch of variables for some reason. --dDnEQgWzhgf+8aPe Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJV1hnPAAoJECTWi3JdVIfQWHcH/A2n4Ej3jYZ0ewdd4kjaiqoD xh6Wa5FqJEMDr+R/kJJtwQs2tb9Ch5j15P/xYQGeYiyhOqX5HiePrYpV4Vvn5j7n hS8LlJkaj5EgB6CKqQ2diN6+tcf/61mjF+tiU+BoWyJA6HN0SjHNQOtvYmolvawI Iim2vtjIW7UtUq/3r7V8zidi0f5HEb9xZCBrbUmq0adrJmxOLKmhEo8F4ONwWOGk 77vwGgMeTpYAQGBpMKb3ga6BmcdLf+UzVDilHcr6xFXWhcEF+xcpvM6UR0WyxHJ+ peECbSrsTLHnOTehnapOh8esDShgABz66YuqF14/CsMrpMtSooTnJZXgTNRs38E= =HL3K -----END PGP SIGNATURE----- --dDnEQgWzhgf+8aPe-- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/