Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752665AbbHTSaO (ORCPT ); Thu, 20 Aug 2015 14:30:14 -0400 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:54020 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751585AbbHTSaL (ORCPT ); Thu, 20 Aug 2015 14:30:11 -0400 Date: Thu, 20 Aug 2015 11:30:03 -0700 From: Mark Brown To: Markus Pargmann Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kernel@pengutronix.de, Irina Tirdea Message-ID: <20150820183003.GL12027@sirena.org.uk> References: <1440061956-29064-1-git-send-email-mpa@pengutronix.de> <1440061956-29064-5-git-send-email-mpa@pengutronix.de> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="eMP3JyRexyk9c0Bv" Content-Disposition: inline In-Reply-To: <1440061956-29064-5-git-send-email-mpa@pengutronix.de> X-Cookie: You are fairminded, just and loving. User-Agent: Mutt/1.5.23 (2014-03-12) X-SA-Exim-Connect-IP: 69.84.245.29 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH v2 4/5] regmap: regmap_raw_read return error on !bus->read X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1276 Lines: 34 --eMP3JyRexyk9c0Bv Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Aug 20, 2015 at 11:12:35AM +0200, Markus Pargmann wrote: > Return -ENOTSUPP if map->bus->read is not implemented and we do not use > the cache. This code path would directly use bus->read would run into an > NULL pointer for the read function. Please put fixes like this before coding style changes like patch 3. --eMP3JyRexyk9c0Bv Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJV1hyqAAoJECTWi3JdVIfQcQkH/izrMOp4cAwqdetMIf3HdUAl AlEOgRpTUPuWUilJhS6wXnU3cTyLEBBkEVh9qGNgFZWvGGg02j1S/IZbT22ocZRJ YpiX0/G+IpeZXf2V+hnMsvJUkGK4Du5vW+llg9rWFj4sXPZTiZdX2ChinOLoAyLN KXSjeYtFoiFLzaE1O/NS4bfEWWO5Od2PX2r7IYwDjuUduRXaMt3xeJ+M1MxneYXy R6dbh5xCuIS9sjtcMFwXKtI6O7BGmtrCSGzdlP3QXc/nLSBv8bVgtuqdHUl5ADoF sHrMDSgQCVTTozgjj1KjBI1MLXekYBWC6Yl9suQtNH69B0BL6e4pq8liVzypg9I= =a3Sf -----END PGP SIGNATURE----- --eMP3JyRexyk9c0Bv-- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/