Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752433AbbHTSoL (ORCPT ); Thu, 20 Aug 2015 14:44:11 -0400 Received: from mail-bl2on0085.outbound.protection.outlook.com ([65.55.169.85]:31841 "EHLO na01-bl2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751707AbbHTSoI (ORCPT ); Thu, 20 Aug 2015 14:44:08 -0400 Authentication-Results: spf=fail (sender IP is 66.35.236.236) smtp.mailfrom=opensource.altera.com; codeaurora.org; dkim=none (message not signed) header.d=none; Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=dinguyen@opensource.altera.com; Message-ID: <55D61E7C.40609@opensource.altera.com> Date: Thu, 20 Aug 2015 13:37:48 -0500 From: Dinh Nguyen User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Mark Rutland CC: "robh+dt@kernel.org" , "ijc+devicetree@hellion.org.uk" , "galak@codeaurora.org" , Pawel Moll , Catalin Marinas , Will Deacon , "dinh.linux@gmail.com" , "jszhang@marvell.com" , "devicetree@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCHv2] arm64: dts: Add base stratix 10 dtsi References: <1439308127-7412-1-git-send-email-dinguyen@opensource.altera.com> <20150820172308.GA2711@svinekod> In-Reply-To: <20150820172308.GA2711@svinekod> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-Originating-IP: [64.129.157.38] X-ClientProxiedBy: CY1PR20CA0099.namprd20.prod.outlook.com (25.164.213.153) To CY1PR03MB1374.namprd03.prod.outlook.com (25.163.16.28) X-Microsoft-Exchange-Diagnostics-untrusted: 1;CY1PR03MB1374;2:VoIioRKbGnWUdUAY6eJRMeJecdTOq+KdI2CYNplkwFJzut64MHbFL/n0DT6wqcKrTFqsd4QmgkPVdX7jHuEArSxjU2R0hv57F+tQMxYdm+SHEnOkXmb3r9bUS0rDX8ROTXYSQjMR2swR4htvG9ciXLCxd5xeFNWcgfoAkTBkG0k=;3:63bzrz8nEuH4Xe+jHJfDebb9O31k2jQthcS7CJT6RHtnAxs8Ra7dYDFllErgvSicnHCo+bb4Wll3oL7Cb9ymLgEfqZApOtj7TUZYYB+MjKw0HMtRjfcRVoDbDbS8UhPW5YAmpAZ8rFQVxHBLq1eyPQ==;25:DIXKQFaCdzc8iCrjbBNe1rMlNsa45/2AuRTh5BQa6iG82TCDyx/Us82YXmJY2+PI57uFpxOTuv4Uft77FXv94o4xksFXMx/L9W107zuBWnKhG2Nd5EEZ+hJZQnElTEIC01ke5TDGJvY499zeJ36Gv0eRR2OURTseZpql0s/NXVEKcdWQztTvluaNLENUWupUAp1Dh8sSEDu8vagXXjYQ7Y31h+HXtLuvP2RBOMFxlqHRoCiiAjJ10ap6sdPc3S4x;20:0YW3QI4cqVah8R5wZ9y8lN12j5Y7I3KKouDytOq8YAFD0c35czozpT7gFSyD/TDjMT9K20DF/rKrkJOdY0DI5UwF+4TxRLmh4J5f1D8l89XoI1PSHGfIZBBz8DNak98GEwtbczQ6ombXBrt4FUT8YcP5EMQMyMCqzX5UXUgxiZ0= X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:CY1PR03MB1374;UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BLUPR03MB1489; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:;UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(5005006)(8121501046)(3002001);SRVR:CY1PR03MB1374;BCL:0;PCL:0;RULEID:;SRVR:CY1PR03MB1374;BCL:0;PCL:0;RULEID:(601004)(8121501046)(5005006)(3002001);SRVR:BLUPR03MB1489;BCL:0;PCL:0;RULEID:;SRVR:BLUPR03MB1489; X-Microsoft-Exchange-Diagnostics-untrusted: 1;CY1PR03MB1374;4:mw8LAlunbLIu8zdMyQEegONLBrcdona6UimBrbGmxnHb8/P/8+p5t86/xAUnNz4A+gTTnLd2hMB8uO6gdYFQn6/h4JLe3HoOMBmZ2qP5W9Cd5gIGwcgHtLyC6SO4csBN3/JnHe6Fwo6RJcUA4M1dywjbkHW0DXFc9lbNh37Ptzo0Ymoj8XzLUHvTGvi0ejB9zw+uhLixcz4yiaiEQhW51IIN3jNpppeEEdjvs73zBL3d58/qT1EkYJYrklqclrHpdknRWo9ayxyHE5ZTdtiogiW+4Qgy2y1rq65inMcX3No1Ctc873IDZ2ONGx7Vjqqm X-Forefront-PRVS: 0674DC6DD3 X-Forefront-Antispam-Report-Untrusted: SFV:NSPM;SFS:(10009020)(6049001)(6009001)(189002)(52604005)(24454002)(479174004)(199003)(377454003)(54356999)(77156002)(87976001)(81156007)(92566002)(5004730100002)(5007970100001)(50466002)(105586002)(47776003)(76176999)(50986999)(83506001)(77096005)(4001540100001)(40100003)(106356001)(23746002)(46102003)(62966003)(64126003)(33656002)(68736005)(65816999)(65956001)(122386002)(5001860100001)(5001830100001)(4001350100001)(575784001)(19580405001)(97736004)(110136002)(64706001)(2950100001)(65806001)(86362001)(66066001)(42186005)(101416001)(189998001)(5001960100002);DIR:OUT;SFP:1101;SCL:1;SRVR:CY1PR03MB1374;H:[137.57.160.210];FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:0;LANG:en; X-Microsoft-Exchange-Diagnostics-untrusted: =?Windows-1252?Q?1;CY1PR03MB1374;23:HJyVviRjbqbuhx/00JoFMQ7bh+Fbe8nxzOpns?= =?Windows-1252?Q?7ZEJfDnGKXzm5eRd3dEL0MA5YK4lLoNZXqxtFDEr4hf5jPdW0EnUfO8l?= =?Windows-1252?Q?vQnSNsJ8fxhjQPryrL1dqnND4T9CH99sP3ftex5EArCTpYZNYswU9MqY?= =?Windows-1252?Q?9A6Kogh8MmcUdJ4r2q84wsY6//WzsdRpJ4NGTolY6/F2l5KFa2pBS2OK?= =?Windows-1252?Q?q7pYc46NkvnYehpuIesX82wluH8Q1Lvlou4j65wmnyozVL9GpIiMWLIB?= =?Windows-1252?Q?ig8WbQzZjs08t5j94MsJ3+ATDf0B4nO5ptQZqRlR0UO7wa994DZE/avf?= =?Windows-1252?Q?3ldg5G93uHSMFtjlpJRywwbyctolXv1wBpLb3swhFEY3Y1D0c1Jaigg+?= =?Windows-1252?Q?ghsenum9OSRSQhnS6Pe+Sp8PnJ4RW4HQmuXngnjqFglx3x5BWybbWqPZ?= =?Windows-1252?Q?NHQ8N8f0Io2Fq4+EoGdX45y+IvCxtWJkkfDJMrqYC3yp/rmfPy9+0CZ3?= =?Windows-1252?Q?tlC9k9aOrMluKro5Hnjrd+rk/Far16eeQP3LaXrAt+yGKoAJfxciN0gN?= =?Windows-1252?Q?bZsZoxlIaIxshLAIdFnbCQ6HPIy1yoUBNPcNBCg5l8UvwNpqaZ2N/7QO?= =?Windows-1252?Q?rD2uLiyJ/1FxT5CsEYlSIhuan+hIqf8u1dtVqorYpZyjWlHwJ/fqT+Sv?= =?Windows-1252?Q?oTS2jprHRTAU7GIWNB7IdQhfVOsdVjGC3qifmwmyHP9U/gnes1NEY87v?= =?Windows-1252?Q?oaIo1kGJb8iM8aGEy5/urj9KvkqJ1jRRByW0AgZnrreE5fABNndZzUkB?= =?Windows-1252?Q?i6+SLuKZmgrAy5FW4+kw5f50m5rHe3yR1xoTllY9WHlBYqnYoQnx/Umz?= =?Windows-1252?Q?vgBkvIV3ugZvwtdGvgTnrHZJjYg5o8TWBP3KfUqF3zJfUt7prG5vINpO?= =?Windows-1252?Q?KOXeLJx16PiVj9yTEpLGBZPebUIMd5Ga7seKm1C2b/AiSYbmKebeh5wG?= =?Windows-1252?Q?fm9yvuaVPO4KkMZQwl47WZ5+KO7VAiXvmlrg0rP2aXU6y/ZAi9TpfRnj?= =?Windows-1252?Q?eaULqjPJVCR61g0qICvzp8p8HAn9n1t353FTRTp0e8IDNKCy+1HDN6Nt?= =?Windows-1252?Q?qrhPbA+sq0RH7CngyVp3VMq/h65Gf/ylyqjQlfpqA/DHrQE05fXZxq/M?= =?Windows-1252?Q?WNkW/x/LadFnJXb+JjEKc/DDyWpUuuSA6X8mRjfAcctR5yWmcCbkmiN9?= =?Windows-1252?Q?xbSLIyru0rV6IlAG71nbxxtohXvGq85nVOfV4LxOWkE8jkUIPmCOsDmd?= =?Windows-1252?Q?oZPAdD0JZOXVis7Y+/05ZPmn8UoaUOJiEHktm6kmygsZ8k7Oq9lmHoBS?= =?Windows-1252?Q?sNo0m2TwBiRLUL/Jj2QLl5Cc10x88+raa8oVufqNAe/bh8F/XcNjEOuZ?= =?Windows-1252?Q?Jrauo56/faAc3BAn8TO?= X-Microsoft-Exchange-Diagnostics-untrusted: 1;CY1PR03MB1374;5:QJkG/b5Yjvtx2/g2zbB50ktQLSaDt3lnvafcZ1f9sjpe/hLR8ZYMlt147tN18OIyyglx73i7f+TdzQoBd9SPIZcdKrueBu/bOI/XXqsFWN2Gdu5M9O9ygroU2aUt9TM4y4GYxCbamKKSVJOpWLhDOw==;24:zjM7lDwILP38D64XC7nifHP22Sdk7eiJXE4r4bEoDtTeUHAt5aI4GyPijfk9SK+bcojkBlDFcfj1m5W5vt1MmxGxkgMBQlZH4MmOpCy1D2U=;20:wuB8FJwc0Soj5Mgl3KE4rUj42dA/NwW+sbEiU40cMmZty8uQBgPAZLmb7tY5w0ZWXtc+wIxQuervi6H/o0Y3JaTtDROGHoogEiqo30AjTN3Al56Pv6dduVSLiG2PXoRqST/iuNh3SL/YouvujBYtevYwfql8NaPMUaYh4PGbeWQ= SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR03MB1374 X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: BN1BFFO11FD034.protection.gbl X-Microsoft-Exchange-Diagnostics: 1;BN1BFFO11FD034;1:j3XovV2276Tyab0wkLxaAAnJks7F2VsRXw0IIRbx8C5g5qz5EGCblRGqUSAyVRhrfkh3YpoXQd1upadIw4fFoQa9wJSUFzYijavvsgvUfVzOrzgeyLYpkX12GnIqu+sDg196LN7QJwuEgFBm0hcdSGL9lr0SfrqOJIPmFyw/lFu+3dYNR2BTItFbJgGTTQJlEbDjBfYd5CHDeagtbCX6N7Vs6Eyp3hiZFFg1Yvn7zWYu4mzf8TX7UO4+f8SK0pP8hFeagPD9aAmokN1BhjcbYxOj0IcYJp9A4Cw0KtEGDGsrQtNfkM7ob0CgYQSJ2JgphZXCqz0TQQltAM+blb71W51nAMtrYP2GJOk1JfcPkkf926sKJA8/1ToJ/tmvhzlv X-Forefront-Antispam-Report: CIP:66.35.236.236;CTRY:US;IPV:NLI;EFV:NLI;SFV:NSPM;SFS:(10009020)(6009001)(2980300002)(3050300001)(339900001)(189002)(199003)(24454002)(52604005)(479174004)(377454003)(122386002)(50986999)(110136002)(54356999)(97736004)(46102003)(66066001)(23746002)(77096005)(83506001)(189998001)(5001860100001)(76176999)(16796002)(65956001)(47776003)(5004730100002)(65806001)(64706001)(50466002)(68736005)(6070500001)(4001350100001)(62966003)(5007970100001)(65816999)(5001830100001)(85426001)(77156002)(21840400001)(33656002)(64126003)(5001960100002)(4001540100001)(40100003)(105606002)(90366008)(81156007)(2950100001)(106466001)(6806004)(86362001)(92566002)(87936001)(575784001)(19580405001)(7099028);DIR:OUT;SFP:1101;SCL:1;SRVR:BLUPR03MB1489;H:sj-itexedge04.altera.priv.altera.com;FPR:;SPF:Fail;PTR:InfoDomainNonexistent;MX:1;A:0;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;BLUPR03MB1489;2:YEUU9mJRyyOAE8lbNNWe4zmEZaLnRxN/l6nsK6cXfOh+Ml2N7FpLg18CMRHEX69bvvSUbpEL1ouEuGqLX/KkqDTt+1PudaPB/3vQAPW+oA+ZzVYNwAgygD0e0o0GWDTcdXcdH+3ndlTbNap4eCum4yIu0U5DDiWy79uQ8swGFhs=;3:j7beSYP1BTfCfnsVJsLQzJgDLD4Nt5QLRZxpBjDtslwuGFyMP4v6s9/5xZzoRO3mA9wUUR/gROade2N8sGymEUt2tEurG6aiDax7LWrL6FM/S28osGy0UnAFqmwM29EXIZoyNcQ3/X1wN4aAt4O+7VWbgRmM6aWk9L2YC/bQgct6ZqrSs9Q/b7jmVNpgLB38G2KVwvXUMkpXA2uppBgw9qqcpvYq539GDZQOHkqffcs=;25:hPcUZLYRvy3ICk2n1ixXdytBrYpnQMc+WogEn3+DFlrIYXI+SG46jgcgcysVbySx5WeiYFIp0gk7Gkqj1yWoKeFFkybZE+beNGhBpowrKfIqlsFuSO3i5WaWD4PxsNeFnqzhDdxNLoyWO5Foy0erF8oAct6o3AcJ2u2/RE/ggTZm1ZF7S+UMxtwUa5XU/Eizo7BpRw1L8u9vdr0aFNadZH6bhcmzKsKdTgpLgXliV7KrsSMKLwnSs4Xjv/4nNn/9;20:Ud8HNUbGJ+LjpC4XYZf/9294zKHvYRl0Qs2LO/Bg5yHHFFR0gKOHqqDy27prDlc/hPpTfJwEcnX3t2seYNAxrbiXwRzArCEy+bPCIFC5ibOCRebm8cE5TBa54mSxYY/PS0XNbUP/U3Yk57ktXm8e5WgN8Gh1MQlzE1ol5qbJh+k= X-Microsoft-Exchange-Diagnostics: 1;BLUPR03MB1489;4:XOsUpv3AnUtl1m3QYOSoxLoSRL0Dg6nRhv0CdrMVcyib/Sw0z9aOTVyECu9MRHu5KSQWIf8IzVnEtCo8dmqP+BjRicZB6k4+MbCtoI87nYS01FZgH2Oxukjcb3sBd/wGWl/cTTrWXAxFvfQ5LSMlz1+SvOMFXlIENc47uHx8WvDveQgkSAaY+w1F2FyFxKZ/r/DJylq/InxSlmsYeCzAaBPAiMRqb6PxuesG2CL6mhd2ujP/qHYvAUMWkbHIjtxHdKPA9fL5vOT/+kHpkQY958e6nEXI74dxKphmpxI5/qkaww9e/Q9sKNZFHFD1ucu0 X-Forefront-PRVS: 0674DC6DD3 X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1;BLUPR03MB1489;23:S1GXIf8/RH0GGcRKoU2XH1iZH3NI9faYKxrSA?= =?Windows-1252?Q?FbbpMM509pUnNN9oXRPlK6nZFdx3c25xxeOj55CfLk9NTDEVri/UXK6I?= =?Windows-1252?Q?XeVSMPkKuiqkIe3lRJpGqSmAk55k7iiAo7TKjNO3gq2Ms0yDZ8lWpVvq?= =?Windows-1252?Q?RFeJpAZIm7pWZn4uWIoaz2KaBTb3H7rvP3TZ0CIJkb9s2SlL4Lcmt75U?= =?Windows-1252?Q?6ORl/agaRDtlcarOJoqPNVA14kX67WKgKIGJqD735rCLSG5kFTENIhmq?= =?Windows-1252?Q?QfnAaZbw+iq7XnUSZWdp5pIx/chj69RjFeL0cssyh5uF18JAd9GacJfG?= =?Windows-1252?Q?DAeqg45Eatqfl5FIsAAK7SImpLLEbsfZYTTV63n2VUecw7H0LOamBmi+?= =?Windows-1252?Q?d6queYvUxRlo7iVQEfjWPsuf5gOSoS8baiTgKEAlRJZcjrNAYGjs6lXa?= =?Windows-1252?Q?f5j9ytdxm95TFyIcif5UN96pOogRavi7TQpM1inuC0AhjcMv8nbsiIVK?= =?Windows-1252?Q?cvo9jYNUD8SXRs3sgz9jP05alrFSWEtD+rU/rF1Lv7qVhnQaYZ9Xiknk?= =?Windows-1252?Q?fZ03NBXx7kLz1U/x5p25KSUSAUMRUiDokvceWA/qzdXZVy35JzZCdTgZ?= =?Windows-1252?Q?nH3KwVHUjizMYL7d+LtRtpt0Kqq8e2aEo5NFzffej6vcsMRjh4x96b53?= =?Windows-1252?Q?jo93IvcYio9o1NkTuwJmwuqAzdPJdTuwyoTwc818pSGUSlUD5S81Dbmd?= =?Windows-1252?Q?GlkFz4OCkOEqUvxTB+yCLhYYwddwxcrm1Jv6awsSV6YG0FNgW+WunSiT?= =?Windows-1252?Q?/4yUSURyS1Tg9kuncm233u1QQ8PgAy8gUyD8IrKVLlg/3cFguP0QWUUx?= =?Windows-1252?Q?x+iUpUJ6ScUt3goHJct+xSV8IIqbCAq7pgdLwxYB5++IIfFlQbLv4j8/?= =?Windows-1252?Q?oNFj+ypmpC4H4jJBH1UT2xtPSnB62tbuugR8st8AbiDAd7ZZwGii/BGA?= =?Windows-1252?Q?LOtlKyBBgAx8H4nwIKkaDKhLOlnppC9WQVTy2X8ApGu+I5KTFeX+GK5y?= =?Windows-1252?Q?/taDRVwnt1SV2cfLKY0CAQu1UEl6Wss1T1S+0LUiO0gsguwuzaK3GJCS?= =?Windows-1252?Q?Z6/iuLEozPQX/EBm4j1nRQysIYWB+W6kfnJ04QCLe+HqhRSbAlE/Km1Q?= =?Windows-1252?Q?gaUDeD1WwyQs+/yJJmGjtA7sLcJ+MM6ADkH3Lk4ZYDUFZr8WaatWxXWd?= =?Windows-1252?Q?lKXzCcNYNcAkZ19MRIPDDjdOFpiLRDAKQpdnMwvcihGCROsiTL+vEQXR?= =?Windows-1252?Q?Iqp69S53ULhYK6WXxAFbmSNhxAEp7qtT4Vq50gtQOszywUGSlRlICY3f?= =?Windows-1252?Q?UZiLn+UtDjirvt32e7km7lGtTCNkwSH+j6oMXv4/N7BD0T/GzFMaIxeV?= =?Windows-1252?Q?0KaQeWsT2Khhl6g5+0rAALQ37/yuTzj5X9OLjSZj0m0eAV1K6CkJW/Pt?= =?Windows-1252?Q?ofSKj5Zifja0rwuDKRA75tbrgF5wh1M55DFaKyhJEyDk7pqP0DPTKEHX?= =?Windows-1252?Q?nJusK9dZJqiYFw+C7NzNanBgKQcXJHbmPpYKN8EFG4fiobN4PMiowr3i?= =?Windows-1252?B?QT09?= X-Microsoft-Exchange-Diagnostics: 1;BLUPR03MB1489;5:tb6WgBRNuYo7dvumAE4teMEG7DVMmy+BGUV1ZkT9vwGGiH3+EXQqr+xeV+xexoQg+Nh3qMGiUpwTT+I7ZV44qul5ssv2W0Cxpjp41lXi8zb+h8LV5gYnSwYx6qu/BG7KUNt4Rpu4orUw4Uk48IifJw==;24:O6wcL7+SVVl0NuMfj8FwXqFXvgK36W1SaUnngte5jcoopE3SvFS5oLG5zaN1on2FhvxJaSQGB+bWg6Mpi59DJqBw7lx/eYuo4M5uYMPLA/Q=;20:bc93sGdd9KMygkPdPyU3QWHVRQTPcDZSiBW5E+asAQhZQjbAsGArqyto1KrSJRellHzn8LwZzKDzPvPzkIqpyswKyjRMEvWyqKfs/RmCJUR/PgoE2W9eKvEDmJGTRpEhzA00qKGxhjBKoq47Cl0Td3tiMqo7s5MA4Ao6/Q4aILo= X-OriginatorOrg: opensource.altera.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Aug 2015 18:44:05.2683 (UTC) X-MS-Exchange-CrossTenant-Id: fbd72e03-d4a5-4110-adce-614d51f2077a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=fbd72e03-d4a5-4110-adce-614d51f2077a;Ip=[66.35.236.236];Helo=[sj-itexedge04.altera.priv.altera.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLUPR03MB1489 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1616 Lines: 59 On 08/20/2015 12:23 PM, Mark Rutland wrote: > Hi, > >> +/ { >> + compatible = "altr,socfpga-stratix10"; >> + #address-cells = <1>; >> + #size-cells = <1>; > > I would recommend that you make your root #address-cells and #size-cells equal > to 2, as that will simplify matters later if/when you need to add anything > beyond the first 4GB for some particular board. > > If everything in the SoC falls within the first 4GB you can have a ranges > property on your /soc node and have only one cell below that. > Ok, will update. > [...] > >> + intc: intc@ffff8000 { > > The unit-address doesn't match the first address in the reg entry. > Right, according to the GIC-400 r0p1 TRM, section 3.2 register map, shows that 0x0000 - 0x0fff Reserved 0x1000 - 0x1fff Distibutor ... So even though the GIC address starts at 0xffff8000, the first usable register is at 0xffff9000. I'll have to ask the hw folks if the 0xffff8000 represents the distributor or the reserved block. >> + compatible = "arm,gic-400", "arm,cortex-a15-gic"; >> + #interrupt-cells = <3>; >> + interrupt-controller; >> + reg = <0x0 0xffff9000 0x1000>, >> + <0x0 0xffffa000 0x2000>, >> + <0x0 0xffffc000 0x1000>, >> + <0x0 0xffffd000 0x1000>; >> + }; > > Shouldn't the virtual CPU interface also be 0x2000 long? > Yes, it is. Will update Thanks for reviewing. Dinh -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/