Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752212AbbHTTXz (ORCPT ); Thu, 20 Aug 2015 15:23:55 -0400 Received: from mail-io0-f181.google.com ([209.85.223.181]:36055 "EHLO mail-io0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751727AbbHTTXy (ORCPT ); Thu, 20 Aug 2015 15:23:54 -0400 MIME-Version: 1.0 In-Reply-To: <1440087598-27185-1-git-send-email-klamm@yandex-team.ru> References: <1440087598-27185-1-git-send-email-klamm@yandex-team.ru> Date: Thu, 20 Aug 2015 12:23:53 -0700 X-Google-Sender-Auth: 25nwq858Z7ioPlwRu1zDkhltM1U Message-ID: Subject: Re: [PATCH] mm/readahead.c: fix regression caused by small readahead limit From: Linus Torvalds To: Roman Gushchin Cc: linux-mm , Linux Kernel Mailing List , Raghavendra K T , Jan Kara , Wu Fengguang , David Rientjes , Andrew Morton Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 753 Lines: 17 On Thu, Aug 20, 2015 at 9:19 AM, Roman Gushchin wrote: > + max_sane = max(MAX_READAHEAD, > + (node_page_state(numa_node_id(), NR_INACTIVE_FILE) + > + node_page_state(numa_node_id(), NR_FREE_PAGES)) / 2); No, we're not re-introducing the idiotic and broken per-node logic. There was a reason it was killed. There have been other patches suggested that actually use _valid_ heuristics, this is not one of them. Linus -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/