Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752702AbbHTTpt (ORCPT ); Thu, 20 Aug 2015 15:45:49 -0400 Received: from mail-ig0-f171.google.com ([209.85.213.171]:38425 "EHLO mail-ig0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751728AbbHTTps (ORCPT ); Thu, 20 Aug 2015 15:45:48 -0400 MIME-Version: 1.0 In-Reply-To: <20150820144836.GV30520@lukather> References: <3688fab67e7cdc7bcbff73dfd6b0fcdcc4e79eb6.1440080122.git.hramrach@gmail.com> <20150820144836.GV30520@lukather> From: Michal Suchanek Date: Thu, 20 Aug 2015 21:45:07 +0200 Message-ID: Subject: Re: [PATCH 3/9] spi: sunxi: check that transfer speed is non-zero To: Maxime Ripard Cc: linux-sunxi , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Russell King , Mark Brown , devicetree , "linux-arm-kernel@lists.infradead.org" , Linux Kernel Mailing List , linux-spi Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 897 Lines: 26 On 20 August 2015 at 16:48, Maxime Ripard wrote: > On Thu, Aug 20, 2015 at 02:19:46PM -0000, Michal Suchanek wrote: >> When the maximum transfer speed is not set for a SPI slave the value >> remains 0 and the code in sunxi SPI divides by it. Use an arbitrary >> speed instead in that case. >> >> Signed-off-by: Michal Suchanek > > spi->max_speed_hz is set using the spi-max-frequency property, and > spi->will error out if that property isn't set. What am I missing? > Spidev I guess. You can set the speed to arbitrary value from userspace at any time using the spidev ioctls. Thanks Michal -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/