Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752731AbbHTTr3 (ORCPT ); Thu, 20 Aug 2015 15:47:29 -0400 Received: from www.linutronix.de ([62.245.132.108]:38163 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751576AbbHTTr2 (ORCPT ); Thu, 20 Aug 2015 15:47:28 -0400 Date: Thu, 20 Aug 2015 21:46:50 +0200 (CEST) From: Thomas Gleixner To: Toshi Kani cc: hpa@zytor.com, mingo@redhat.com, akpm@linux-foundation.org, bp@alien8.de, linux-mm@kvack.org, linux-kernel@vger.kernel.org, x86@kernel.org, jgross@suse.com, konrad.wilk@oracle.com, elliott@hp.com Subject: Re: [PATCH v3 1/10] x86/vdso32: Define PGTABLE_LEVELS to 32bit VDSO In-Reply-To: <1438811013-30983-2-git-send-email-toshi.kani@hp.com> Message-ID: References: <1438811013-30983-1-git-send-email-toshi.kani@hp.com> <1438811013-30983-2-git-send-email-toshi.kani@hp.com> User-Agent: Alpine 2.11 (DEB 23 2013-08-11) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 704 Lines: 20 On Wed, 5 Aug 2015, Toshi Kani wrote: > In case of CONFIG_X86_64, vdso32/vclock_gettime.c fakes a 32bit > kernel configuration by re-defining it to CONFIG_X86_32. However, > it does not re-define CONFIG_PGTABLE_LEVELS leaving it as 4 levels. > Fix it by re-defining CONFIG_PGTABLE_LEVELS to 2 as X86_PAE is not > set. You fail to explain WHY this is required. I have not yet spotted any code in vclock_gettime.c which is affected by this. Thanks, tglx -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/