Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752486AbbHTUTc (ORCPT ); Thu, 20 Aug 2015 16:19:32 -0400 Received: from mail-pa0-f50.google.com ([209.85.220.50]:33601 "EHLO mail-pa0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751804AbbHTUTb (ORCPT ); Thu, 20 Aug 2015 16:19:31 -0400 Date: Thu, 20 Aug 2015 13:19:25 -0700 From: Brian Norris To: Alexander Stein Cc: Marek Vasut , linux-mtd@lists.infradead.org, vndao@altera.com, dwmw2@infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, ngachi86@gmail.com Subject: Re: [PATCH] [PATCH v5] mtd:spi-nor: Add Altera Quad SPI Driver Message-ID: <20150820201925.GD74600@google.com> References: <1440053705-3836-1-git-send-email-vndao@altera.com> <201508201003.38179.marex@denx.de> <3030745.IsU6n2jnJj@ws-stein> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3030745.IsU6n2jnJj@ws-stein> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1888 Lines: 46 On Thu, Aug 20, 2015 at 12:06:36PM +0200, Alexander Stein wrote: > On Thursday 20 August 2015 10:03:38, Marek Vasut wrote: > > > +Example: > > > + > > > + quadspi_controller_0: quadspi@0x180014a0 { > > > + compatible = "altr,quadspi-1.0"; > > > + reg = <0x180014a0 0x00000020>, > > > + <0x14000000 0x04000000>; > > > + reg-names = "avl_csr", "avl_mem"; > > > + #address-cells = <1>; > > > + #size-cells = <0>; > > > + flash0: epcq256@0 { > > > + compatible = "altr,epcq256"; > > > + #address-cells = <1>; > > > + #size-cells = <1>; > > > + partition@0 { > > > + /* 16 MB for raw data. */ > > > + label = "EPCQ Flash 0 raw data"; > > > + reg = <0x0 0x1000000>; > > > + }; > > > + partition@1000000 { > > > + /* 16 MB for jffs2 data. */ > > > + label = "EPCQ Flash 0 JFFS 2"; > > > + reg = <0x1000000 0x1000000>; > > > + }; > > > > IIRC, encoding partitions into OF is deprecated (and it shouldn't be > > part of the example anyway, so please remove this bit). > > Do you mean specifying partitions in OF is deprecated in general? Is there any link for that? > What would be an alternative to it? This is the first I've heard of such a deprecation. I would argue that it's still probably one of the best ways to specify partitions. It's not exactly perfect (partitions aren't really "hardware", so may not belong in the "hardware description"), but IMO it's better than cmdlineparts, for instance. I also don't really know of any good-enough, generically useful on-flash partition formats, especially ones that can handle the complexities of NAND. Brian -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/