Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753030AbbHTVXl (ORCPT ); Thu, 20 Aug 2015 17:23:41 -0400 Received: from down.free-electrons.com ([37.187.137.238]:47778 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751842AbbHTVXi (ORCPT ); Thu, 20 Aug 2015 17:23:38 -0400 Date: Thu, 20 Aug 2015 23:23:36 +0200 From: Maxime Ripard To: Michal Suchanek Cc: linux-sunxi , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Russell King , Mark Brown , devicetree , "linux-arm-kernel@lists.infradead.org" , Linux Kernel Mailing List , linux-spi Subject: Re: [PATCH 3/9] spi: sunxi: check that transfer speed is non-zero Message-ID: <20150820212336.GJ30520@lukather> References: <3688fab67e7cdc7bcbff73dfd6b0fcdcc4e79eb6.1440080122.git.hramrach@gmail.com> <20150820144836.GV30520@lukather> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="jcZk2Ix8j3PVOBnV" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2371 Lines: 62 --jcZk2Ix8j3PVOBnV Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Aug 20, 2015 at 09:45:07PM +0200, Michal Suchanek wrote: > On 20 August 2015 at 16:48, Maxime Ripard > wrote: > > On Thu, Aug 20, 2015 at 02:19:46PM -0000, Michal Suchanek wrote: > >> When the maximum transfer speed is not set for a SPI slave the value > >> remains 0 and the code in sunxi SPI divides by it. Use an arbitrary > >> speed instead in that case. > >> > >> Signed-off-by: Michal Suchanek > > > > spi->max_speed_hz is set using the spi-max-frequency property, and > > spi->will error out if that property isn't set. What am I missing? > > >=20 > Spidev I guess. >=20 > You can set the speed to arbitrary value from userspace at any time > using the spidev ioctls. Then why should it be fixed at the controller driver level? It looks more like an issue that impacts everyone and should be fixed either in spidev directly or in the framework. --=20 Maxime Ripard, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com --jcZk2Ix8j3PVOBnV Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJV1kVYAAoJEBx+YmzsjxAgrFEP/0RjiF6rkd+nDL7f06+8Go9T uAlk82P/a4LXAg+mZhY2Pf9UVr2EsB7sJEItVDKZrjHmi9hG8xkLXhE5ds6PiAxC Yp6Sxgb2RiD0ThdzvCeLr34h+xSjsUIsEOV9QjTuymCkfakT0wlO8jUi4EiWybMt qIPRRPpfbMw08AxpZpjcAQJQT04ziWEnzY+cxPP0JDM6Xnc4XaHu4Of4YM8tkFTD 7aYWj95W+tGHUmr/rGGQE/yalAktiAoSL6RdZPB+6IlUX9fY3vOtGnaIh/EoAAyu snQYBYUn8qAMPQZYiAsWH3BFJwSiImDlAEeucqnWdClzriZ5hkL2KlUzG1RG2bVL /nMTJvA7lYXHPfgxSzbcEMpRqNx8v5kDl+qSn/q1sehG6m3cme3krLBJ18JkbVBz 00UwjtqdZERF1jllaDw4uetvyiBha5Qs9OQ2FWF0zPJJrrQNIRtE1ENTIgRw8irn ARCmzG6OfpW4yENxngsbs0KIPqc7Yo0iAM2P8zuVIQg20JSTKaE0N062se/vZPPj iJmppZ8xvZ07JURShdln/OW7F4gWWphW4K/6DhKL3YA/Ol8VlRY2rc3b9fFHZI6W bVhqq6USN6vaZDAA3js7+8iDGL9Km02BUB+F7tM06wSVFsiuOnfx2M5N1gvZTjt6 dm/8TAJgsa5g2pKZK1oE =ZtRK -----END PGP SIGNATURE----- --jcZk2Ix8j3PVOBnV-- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/