Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753192AbbHTXGx (ORCPT ); Thu, 20 Aug 2015 19:06:53 -0400 Received: from down.free-electrons.com ([37.187.137.238]:48966 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751699AbbHTXGv (ORCPT ); Thu, 20 Aug 2015 19:06:51 -0400 Date: Fri, 21 Aug 2015 01:06:50 +0200 From: Alexandre Belloni To: Joonyoung Shim Cc: rtc-linux@googlegroups.com, linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org, a.zummo@towertech.it, cw00.choi@samsung.com, k.kozlowski@samsung.com Subject: Re: [PATCH 1/4] rtc: s3c: add missing clk control Message-ID: <20150820230650.GC3769@piout.net> References: <1439292502-22912-1-git-send-email-jy0922.shim@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1439292502-22912-1-git-send-email-jy0922.shim@samsung.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 741 Lines: 21 On 11/08/2015 at 20:28:19 +0900, Joonyoung Shim wrote : > It's missed to call clk_unprepare() about info->rtc_src_clk in > s3c_rtc_remove and to call clk_disable_unprepare about info->rtc_clk in > error routine of s3c_rtc_probe. > > Signed-off-by: Joonyoung Shim > --- > drivers/rtc/rtc-s3c.c | 3 +++ > 1 file changed, 3 insertions(+) > Applied, thanks. -- Alexandre Belloni, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/