Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753188AbbHTXnI (ORCPT ); Thu, 20 Aug 2015 19:43:08 -0400 Received: from mail-vk0-f49.google.com ([209.85.213.49]:33898 "EHLO mail-vk0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751699AbbHTXnF (ORCPT ); Thu, 20 Aug 2015 19:43:05 -0400 MIME-Version: 1.0 In-Reply-To: <1440079144-26461-7-git-send-email-ygardi@codeaurora.org> References: <1440079144-26461-1-git-send-email-ygardi@codeaurora.org> <1440079144-26461-7-git-send-email-ygardi@codeaurora.org> Date: Fri, 21 Aug 2015 08:43:03 +0900 Message-ID: Subject: Re: [PATCH v2 6/8] scsi: ufs: make the UFS variant a platform device From: Akinobu Mita To: Yaniv Gardi Cc: Rob Herring , Jej B , Paul Bolle , Christoph Hellwig , LKML , "linux-scsi@vger.kernel.org" , linux-arm-msm@vger.kernel.org, Santosh Y , linux-scsi-owner@vger.kernel.org, Subhash Jadavani , Gilad Broner , Dolev Raviv , Vinayak Holikatti , "James E.J. Bottomley" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1438 Lines: 34 2015-08-20 22:59 GMT+09:00 Yaniv Gardi : > @@ -1036,7 +1037,7 @@ void ufs_qcom_clk_scale_notify(struct ufs_hba *hba) > * The variant operations configure the necessary controller and PHY > * handshake during initialization. > */ > -static const struct ufs_hba_variant_ops ufs_hba_qcom_vops = { > +static struct ufs_hba_variant_ops ufs_hba_qcom_vops = { It's better to keep const. In order to do this, we also need to put const to 'vops' member in struct ufs_hba and the second argument of ufshcd_pltfrm_init(). > +static void ufs_qcom_shutdown(struct platform_device *pdev) > +{ > + ufshcd_shutdown((struct ufs_hba *)platform_get_drvdata(pdev)); > +} We don't need this function anymore since we have ufshcd_pltfrm_shutdown() now. > -static void ufshcd_pltfrm_shutdown(struct platform_device *pdev) > +void ufshcd_pltfrm_shutdown(struct platform_device *pdev) > { > - ufshcd_shutdown((struct ufs_hba *)platform_get_drvdata(pdev)); > + ufshcd_shutdown((struct ufs_hba *)platform_get_drvdata(pdev)); Whitespace is used as code indent. There are same issues in this patch series, so I recommend running checkpatch.pl before sending patches. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/