Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752635AbbHUAOO (ORCPT ); Thu, 20 Aug 2015 20:14:14 -0400 Received: from lists.s-osg.org ([54.187.51.154]:58965 "EHLO lists.s-osg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752179AbbHUAOM (ORCPT ); Thu, 20 Aug 2015 20:14:12 -0400 Subject: Re: [PATCH 1/4] [media] staging: omap4iss: get entity ID using media_entity_id() To: Laurent Pinchart References: <1439998526-12832-1-git-send-email-javier@osg.samsung.com> <1439998526-12832-2-git-send-email-javier@osg.samsung.com> <3021244.b1huftRsSL@avalon> Cc: linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org, Mauro Carvalho Chehab , Greg Kroah-Hartman , linux-media@vger.kernel.org From: Javier Martinez Canillas Message-ID: <55D66D4D.2030307@osg.samsung.com> Date: Fri, 21 Aug 2015 02:14:05 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.0.1 MIME-Version: 1.0 In-Reply-To: <3021244.b1huftRsSL@avalon> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1218 Lines: 34 Hello Laurent, On 08/20/2015 08:37 PM, Laurent Pinchart wrote: > Hi Javier, > > Thank you for the patch. > > On Wednesday 19 August 2015 17:35:19 Javier Martinez Canillas wrote: >> The struct media_entity does not have an .id field anymore since >> now the entity ID is stored in the embedded struct media_gobj. >> >> This caused the omap4iss driver fail to build. Fix by using the >> media_entity_id() macro to obtain the entity ID. >> >> Signed-off-by: Javier Martinez Canillas > > This looks fine to me. The patch needs to be moved between Mauro's 1/8 and 2/8 > patches to avoid breaking bisection with patch 3/8. I'd squash this patch and > 2/4 into a single "media: Use media_entity_id() in drivers" patch. > Yes, Hans and Mauro already mentioned it and I completely agree that should be squashed with Mauro's patch to maintain git bisect-ability. Best regards, -- Javier Martinez Canillas Open Source Group Samsung Research America -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/