Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753259AbbHUAo7 (ORCPT ); Thu, 20 Aug 2015 20:44:59 -0400 Received: from mailout1.w1.samsung.com ([210.118.77.11]:46652 "EHLO mailout1.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751249AbbHUAo4 (ORCPT ); Thu, 20 Aug 2015 20:44:56 -0400 X-AuditID: cbfec7f5-f794b6d000001495-8c-55d67485f451 Message-id: <55D67487.3040503@samsung.com> Date: Fri, 21 Aug 2015 09:44:55 +0900 From: Krzysztof Kozlowski User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.8.0 MIME-version: 1.0 To: Alexandre Belloni , Joonyoung Shim Cc: rtc-linux@googlegroups.com, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, a.zummo@towertech.it, sbkim73@samsung.com Subject: Re: [PATCH] rtc: s5m: fix to update ctrl register References: <1439455764-23526-1-git-send-email-jy0922.shim@samsung.com> <20150820231551.GE3769@piout.net> In-reply-to: <20150820231551.GE3769@piout.net> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrILMWRmVeSWpSXmKPExsVy+t/xy7qtJddCDV73SVksuXiV3aLj2mIm ixf3LrJYvH5haHF51xw2ixnn9zFZ7O/sYLS4uOILk8WCjY8YHTg9nmy6yOixZ+JJNo++LasY PabP+8nk8XmTXABrFJdNSmpOZllqkb5dAlfGy9VX2Qou8FZc+T+BuYHxE1cXIweHhICJxK67 3l2MnECmmMSFe+vZuhi5OIQEljJK3Jn+lAnC+cIocWbrVxaQKl4BLYnGd6+YQZpZBFQlWs96 gYTZBIwlNi9fwgZiiwpESCxffZIRolxQ4sfke2CtIgIZEtvO/GQFmckssIxRYuXBVnaQOcIC VhIfTmeA1AgJZEtce36HCcTmFNCT+HxnCytICTOQff+iFkiYWUBeYvOat8wTGAVmIdkwC6Fq FpKqBYzMqxhFU0uTC4qT0nON9IoTc4tL89L1kvNzNzFCAv7rDsalx6wOMQpwMCrx8M6IvBYq xJpYVlyZe4hRgoNZSYS30gYoxJuSWFmVWpQfX1Sak1p8iFGag0VJnHfmrvchQgLpiSWp2amp BalFMFkmDk6pBkb/9edndoqpLug12228uk5t6RrPyr4WFu6sgvrvk5lD4mxnfW6LDdyh9XzH BddfiY90vWdEX7fae0I6ufBy6M66P3NWRN59HlDS/ii/XPL7s1h36zbDm6l1rKo1LOultC+Y r8mKOihtncG/3N5NtPC4vs+1JK4zGhML7ZoTvu96OsuzyNgqRomlOCPRUIu5qDgRAJ/74xZ0 AgAA Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1935 Lines: 59 On 21.08.2015 08:15, Alexandre Belloni wrote: > Hi, > > On 13/08/2015 at 17:49:24 +0900, Joonyoung Shim wrote : >> According to datasheet, the S2MPS13X and S2MPS14X should update write >> buffer via setting WUDR bit to high after ctrl register is updated. >> >> If not, ALARM interrupt of rtc-s5m doesn't happen first time when i use >> tools/testing/selftests/timers/rtctest.c test program and hour format is >> used to 12 hour mode in Odroid-XU3 board. >> > >>From what I understood, I should expect a v2 of tihat patch also setting > RUDR, is that right? OR would you prefer that I apply that one and then > fix RUDR in a following patch? Right, I would expect that as well... or a comment if this is not needed. Best regards, Krzysztof > >> Signed-off-by: Joonyoung Shim >> Cc: > > can you update the stable tag with the kernel version introducing the > issue? > >> --- >> drivers/rtc/rtc-s5m.c | 12 ++++++++++++ >> 1 file changed, 12 insertions(+) > >> diff --git a/drivers/rtc/rtc-s5m.c b/drivers/rtc/rtc-s5m.c >> index 8c70d78..03828bb 100644 >> --- a/drivers/rtc/rtc-s5m.c >> +++ b/drivers/rtc/rtc-s5m.c >> @@ -635,6 +635,18 @@ static int s5m8767_rtc_init_reg(struct s5m_rtc_info *info) >> case S2MPS13X: >> data[0] = (0 << BCD_EN_SHIFT) | (1 << MODEL24_SHIFT); >> ret = regmap_write(info->regmap, info->regs->ctrl, data[0]); >> + if (ret < 0) >> + break; >> + >> + ret = regmap_update_bits(info->regmap, >> + info->regs->rtc_udr_update, >> + info->regs->rtc_udr_mask, >> + info->regs->rtc_udr_mask); > > Very small indentation issue here, it should be aligned with the open > parenthesis. > > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/