Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753319AbbHUArg (ORCPT ); Thu, 20 Aug 2015 20:47:36 -0400 Received: from mail-yk0-f178.google.com ([209.85.160.178]:33188 "EHLO mail-yk0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751762AbbHUAre (ORCPT ); Thu, 20 Aug 2015 20:47:34 -0400 MIME-Version: 1.0 In-Reply-To: References: <1439941188-19293-1-git-send-email-joestringer@nicira.com> <1439941188-19293-11-git-send-email-joestringer@nicira.com> From: Joe Stringer Date: Thu, 20 Aug 2015 17:47:14 -0700 Message-ID: Subject: Re: [PATCHv4 net-next 10/10] openvswitch: Allow attaching helpers to ct action To: Pravin Shelar Cc: netdev , LKML , pablo , Florian Westphal , Hannes Sowa , Thomas Graf , Justin Pettit , Jesse Gross Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2268 Lines: 55 On 19 August 2015 at 15:57, Pravin Shelar wrote: > On Tue, Aug 18, 2015 at 4:39 PM, Joe Stringer wrote: >> Add support for using conntrack helpers to assist protocol detection. >> The new OVS_CT_ATTR_HELPER attribute of the ct action specifies a helper >> to be used for this connection. >> >> Example ODP flows allowing FTP connections from ports 1->2: >> in_port=1,tcp,action=ct(helper=ftp,commit),2 >> in_port=2,tcp,ct_state=-trk,action=ct(),recirc(1) >> recirc_id=1,in_port=2,tcp,ct_state=+trk-new+est,action=1 >> recirc_id=1,in_port=2,tcp,ct_state=+trk+rel,action=1 >> >> Signed-off-by: Joe Stringer >> --- >> v2-v3: No change. >> v4: Change error code for unknown helper ENOENT->EINVAL. > > I got following compilation warning : > > net/openvswitch/conntrack.c:352:42: error: incompatible types in > comparison expression (different address spaces) Is this made available via another sparse flag? It looks like it's related to the __rcu as you've mentioned below, but I'm not seeing this (latest sparse, gcc-4.9.2) >> +static int ovs_ct_add_helper(struct ovs_conntrack_info *info, const char *name, >> + const struct sw_flow_key *key, bool log) >> +{ >> + struct nf_conntrack_helper *helper; >> + struct nf_conn_help *help; >> + >> + helper = nf_conntrack_helper_try_module_get(name, info->family, >> + key->ip.proto); >> + if (!helper) { >> + OVS_NLERR(log, "Unknown helper \"%s\"", name); >> + return -EINVAL; >> + } >> + >> + help = nf_ct_helper_ext_add(info->ct, helper, GFP_KERNEL); >> + if (!help) { >> + module_put(helper->me); >> + return -ENOMEM; >> + } >> + >> + help->helper = helper; > helper is rcu pointer so need to use rcu API to set the value. I know > it is not required here, but it is still cleaner to use the API. Will update, thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/