Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752416AbbHUBAn (ORCPT ); Thu, 20 Aug 2015 21:00:43 -0400 Received: from mailout4.samsung.com ([203.254.224.34]:58330 "EHLO mailout4.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751570AbbHUBAl (ORCPT ); Thu, 20 Aug 2015 21:00:41 -0400 X-AuditID: cbfee68e-f79c56d000006efb-2a-55d67837e78e Message-id: <55D67838.6080902@samsung.com> Date: Fri, 21 Aug 2015 10:00:40 +0900 From: Joonyoung Shim User-Agent: Mozilla/5.0 (X11; Linux i686; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-version: 1.0 To: Krzysztof Kozlowski , Alexandre Belloni Cc: rtc-linux@googlegroups.com, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, a.zummo@towertech.it, sbkim73@samsung.com Subject: Re: [PATCH] rtc: s5m: fix to update ctrl register References: <1439455764-23526-1-git-send-email-jy0922.shim@samsung.com> <20150820231551.GE3769@piout.net> <55D67487.3040503@samsung.com> In-reply-to: <55D67487.3040503@samsung.com> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrGIsWRmVeSWpSXmKPExsWyRsSkQNe84lqowdXPzBZLLl5lt+i4tpjJ 4vULQ4vLu+awWcw4v4/JYn9nB6PFxRVfmCwWbHzE6MDh8WTTRUaPPRNPsnn0bVnF6DF93k8m j8+b5AJYo7hsUlJzMstSi/TtErgyXr34yFLwlr9izvUFrA2Md3i6GDk5JARMJI59mMsEYYtJ XLi3nq2LkYtDSGAFo8Trb+uZYIoOr+uBSsxilDj7sJsJwnnAKLHy50EWkCpeAS2JTSuesYHY LAKqEu0TesC62QT0JO5sOw5miwqESZyZ0QFVLyjxY/I9IJuDQ0QgV+L/4lCQmcwCy4BmHmxl B4kLC1hJfDidAbGri1Fi15NeZpBeTgFtiUXbfjKD1DADzb9/UQskzCwgL7F5zVtmkHoJgWvs Ep+bXrNA3CMg8W3yIbBdEgKyEpsOMEM8JilxcMUNlgmMYrOQXDQLYeosJFMXMDKvYhRNLUgu KE5KLzLSK07MLS7NS9dLzs/dxAiMvtP/nvXtYLx5wPoQowAHoxIP74zIa6FCrIllxZW5hxhN gY6YyCwlmpwPjPG8knhDYzMjC1MTU2Mjc0szJXHeBKmfwUIC6YklqdmpqQWpRfFFpTmpxYcY mTg4pRoYuaZHMuU+tjwcd7L4W7XCDZmP/xKefaw95Z3P5Sa7x/4l164JIZkHo533PLCc8NHz 1OP0WE4nM+WUdb6yLotLI5/nL1XqWfDFY//JLVf9OdYJblknl73ohd7CxknvNY6k3XL99Pum 1Lt/tTE6mmWRjIxbb85JsKl4FTif8XZnT9XhW6nK96aFKrEUZyQaajEXFScCALsGAA25AgAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrMIsWRmVeSWpSXmKPExsVy+t9jQV2zimuhBos3WVssuXiV3aLj2mIm i9cvDC0u75rDZjHj/D4mi/2dHYwWF1d8YbJYsPERowOHx5NNFxk99kw8yebRt2UVo8f0eT+Z PD5vkgtgjWpgtMlITUxJLVJIzUvOT8nMS7dV8g6Od443NTMw1DW0tDBXUshLzE21VXLxCdB1 y8wBukVJoSwxpxQoFJBYXKykb4dpQmiIm64FTGOErm9IEFyPkQEaSFjDmPHqxUeWgrf8FXOu L2BtYLzD08XIySEhYCJxeF0PG4QtJnHh3nogm4tDSGAWo8TZh91MEM4DRomVPw+ygFTxCmhJ bFrxDKyDRUBVon1CDxOIzSagJ3Fn23EwW1QgTOLMjA6oekGJH5PvAdkcHCICuRL/F4eCzGQW WAY082ArO0hcWMBK4sPpDIhdXYwSu570MoP0cgpoSyza9pMZpIYZaP79i1ogYWYBeYnNa94y T2AEuhJhwyyEqllIqhYwMq9ilEgtSC4oTkrPNcpLLdcrTswtLs1L10vOz93ECI7wZ9I7GA/v cj/EKMDBqMTDOyPyWqgQa2JZcWXuIUYJDmYlEd5KG6AQb0piZVVqUX58UWlOavEhRlNgEExk lhJNzgcmn7ySeENjEzMjSyNzQwsjY3MlcV59k02hQgLpiSWp2ampBalFMH1MHJxSDYy9X+OW HTJ6HXSFuf2AgJVe7PGIJNaZDUsMD26bGCF8R3rvRe9vqds7pO55rHOYczp3vrJXeKfQHQNL QUHuXFP7c4ceGr9hVA1gfxuqcl2E17Q+c7Phix+LRQp4YyvKww9Lfbz6cuHLkyETFp7ZMW3r et+Ljl4ubaf2ZJzI5/qRX5VWUj+h67ESS3FGoqEWc1FxIgABsHYYBgMAAA== DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2211 Lines: 68 On 08/21/2015 09:44 AM, Krzysztof Kozlowski wrote: > On 21.08.2015 08:15, Alexandre Belloni wrote: >> Hi, >> >> On 13/08/2015 at 17:49:24 +0900, Joonyoung Shim wrote : >>> According to datasheet, the S2MPS13X and S2MPS14X should update write >>> buffer via setting WUDR bit to high after ctrl register is updated. >>> >>> If not, ALARM interrupt of rtc-s5m doesn't happen first time when i use >>> tools/testing/selftests/timers/rtctest.c test program and hour format is >>> used to 12 hour mode in Odroid-XU3 board. >>> >> >> >From what I understood, I should expect a v2 of tihat patch also setting >> RUDR, is that right? OR would you prefer that I apply that one and then >> fix RUDR in a following patch? > > Right, I would expect that as well... or a comment if this is not needed. > Hmm, the driver only writes control register now, so i don't feel the need of patch setting RUDR for control register. > Best regards, > Krzysztof > > >> >>> Signed-off-by: Joonyoung Shim >>> Cc: >> >> can you update the stable tag with the kernel version introducing the >> issue? Sure, i think it should be v3.16. >> >>> --- >>> drivers/rtc/rtc-s5m.c | 12 ++++++++++++ >>> 1 file changed, 12 insertions(+) >> >>> diff --git a/drivers/rtc/rtc-s5m.c b/drivers/rtc/rtc-s5m.c >>> index 8c70d78..03828bb 100644 >>> --- a/drivers/rtc/rtc-s5m.c >>> +++ b/drivers/rtc/rtc-s5m.c >>> @@ -635,6 +635,18 @@ static int s5m8767_rtc_init_reg(struct s5m_rtc_info *info) >>> case S2MPS13X: >>> data[0] = (0 << BCD_EN_SHIFT) | (1 << MODEL24_SHIFT); >>> ret = regmap_write(info->regmap, info->regs->ctrl, data[0]); >>> + if (ret < 0) >>> + break; >>> + >>> + ret = regmap_update_bits(info->regmap, >>> + info->regs->rtc_udr_update, >>> + info->regs->rtc_udr_mask, >>> + info->regs->rtc_udr_mask); >> >> Very small indentation issue here, it should be aligned with the open >> parenthesis. OK, i will. Thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/