Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753154AbbHUBV2 (ORCPT ); Thu, 20 Aug 2015 21:21:28 -0400 Received: from mailout3.w1.samsung.com ([210.118.77.13]:55315 "EHLO mailout3.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752142AbbHUBVZ (ORCPT ); Thu, 20 Aug 2015 21:21:25 -0400 X-AuditID: cbfec7f4-f79c56d0000012ee-71-55d67d121d71 Message-id: <55D67D14.9060809@samsung.com> Date: Fri, 21 Aug 2015 10:21:24 +0900 From: Krzysztof Kozlowski User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.8.0 MIME-version: 1.0 To: Joonyoung Shim , Alexandre Belloni Cc: rtc-linux@googlegroups.com, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, a.zummo@towertech.it, sbkim73@samsung.com Subject: Re: [PATCH] rtc: s5m: fix to update ctrl register References: <1439455764-23526-1-git-send-email-jy0922.shim@samsung.com> <20150820231551.GE3769@piout.net> <55D67487.3040503@samsung.com> <55D67838.6080902@samsung.com> In-reply-to: <55D67838.6080902@samsung.com> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrELMWRmVeSWpSXmKPExsVy+t/xK7pCtddCDWb9kLNYcvEqu0XHtcVM Fi/uXWSxeP3C0OLyrjlsFjPO72Oy2N/ZwWhxccUXJosFGx8xOnB6PNl0kdFjz8STbB59W1Yx ekyf95PJ4/MmuQDWKC6blNSczLLUIn27BK6MM+tPsBacFqp42n2LtYHxP18XIyeHhICJxJR7 M5ggbDGJC/fWs3UxcnEICSxllDi49i8bSEJI4AujxMa1jCA2r4CWROPS3axdjBwcLAKqEutv i4CE2QSMJTYvXwJWLioQIbF89UmockGJH5PvsYDYIgIZEmc2/GEBmc8ssIxRYuXBVnaQOcIC VhIfTmdA7F3NKDF/zTewBk4BbYkru56C1TAL6Encv6gFEmYWkJfYvOYt8wRGgVlIVsxCqJqF pGoBI/MqRtHU0uSC4qT0XEO94sTc4tK8dL3k/NxNjJCQ/7KDcfExq0OMAhyMSjy8MyKvhQqx JpYVV+YeYpTgYFYS4a20AQrxpiRWVqUW5ccXleakFh9ilOZgURLnnbvrfYiQQHpiSWp2ampB ahFMlomDU6qBsWijmozVTjv33gWlh5yDhBmnVd7aXLquRFNjQlbazHUPLm7ck1yk8ezvxpid 51Tnf12/cNfGuYKGZRFnd7VkzKuI+6U7uyCyON0/qFJQNeX1lNPLzMQv/D8vGNq56abYTn3/ t6E3bk2pWr29417R+oye54vD1mwq8g959mnlzDBrLvbS+bpfOZRYijMSDbWYi4oTAZTBHsJ1 AgAA Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2548 Lines: 81 On 21.08.2015 10:00, Joonyoung Shim wrote: > On 08/21/2015 09:44 AM, Krzysztof Kozlowski wrote: >> On 21.08.2015 08:15, Alexandre Belloni wrote: >>> Hi, >>> >>> On 13/08/2015 at 17:49:24 +0900, Joonyoung Shim wrote : >>>> According to datasheet, the S2MPS13X and S2MPS14X should update write >>>> buffer via setting WUDR bit to high after ctrl register is updated. >>>> >>>> If not, ALARM interrupt of rtc-s5m doesn't happen first time when i use >>>> tools/testing/selftests/timers/rtctest.c test program and hour format is >>>> used to 12 hour mode in Odroid-XU3 board. >>>> >>> >>> >From what I understood, I should expect a v2 of tihat patch also setting >>> RUDR, is that right? OR would you prefer that I apply that one and then >>> fix RUDR in a following patch? >> >> Right, I would expect that as well... or a comment if this is not needed. >> > > Hmm, the driver only writes control register now, so i don't feel the > need of patch setting RUDR for control register. Yes, you're right. There is only regmap_write() (not remap_update_bits()) so your patch is completely fine. Thanks for explanation. Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof > >> Best regards, >> Krzysztof >> >> >>> >>>> Signed-off-by: Joonyoung Shim >>>> Cc: >>> >>> can you update the stable tag with the kernel version introducing the >>> issue? > > Sure, i think it should be v3.16. > >>> >>>> --- >>>> drivers/rtc/rtc-s5m.c | 12 ++++++++++++ >>>> 1 file changed, 12 insertions(+) >>> >>>> diff --git a/drivers/rtc/rtc-s5m.c b/drivers/rtc/rtc-s5m.c >>>> index 8c70d78..03828bb 100644 >>>> --- a/drivers/rtc/rtc-s5m.c >>>> +++ b/drivers/rtc/rtc-s5m.c >>>> @@ -635,6 +635,18 @@ static int s5m8767_rtc_init_reg(struct s5m_rtc_info *info) >>>> case S2MPS13X: >>>> data[0] = (0 << BCD_EN_SHIFT) | (1 << MODEL24_SHIFT); >>>> ret = regmap_write(info->regmap, info->regs->ctrl, data[0]); >>>> + if (ret < 0) >>>> + break; >>>> + >>>> + ret = regmap_update_bits(info->regmap, >>>> + info->regs->rtc_udr_update, >>>> + info->regs->rtc_udr_mask, >>>> + info->regs->rtc_udr_mask); >>> >>> Very small indentation issue here, it should be aligned with the open >>> parenthesis. > > OK, i will. > > Thanks. > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/