Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752941AbbHUFGg (ORCPT ); Fri, 21 Aug 2015 01:06:36 -0400 Received: from metis.ext.pengutronix.de ([92.198.50.35]:53393 "EHLO metis.ext.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751397AbbHUFGf (ORCPT ); Fri, 21 Aug 2015 01:06:35 -0400 Date: Fri, 21 Aug 2015 07:06:28 +0200 From: Sascha Hauer To: Eduardo Valentin Cc: linux-pm@vger.kernel.org, Zhang Rui , linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org, Daniel Kurtz , kernel@pengutronix.de, Matthias Brugger Subject: Re: [PATCH 2/3] thermal: Add Mediatek thermal controller support Message-ID: <20150821050628.GU18700@pengutronix.de> References: <1440057962-13373-1-git-send-email-s.hauer@pengutronix.de> <1440057962-13373-3-git-send-email-s.hauer@pengutronix.de> <20150820222039.GA6708@localhost.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150820222039.GA6708@localhost.localdomain> X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-IRC: #ptxdist @freenode X-Accept-Language: de,en X-Accept-Content-Type: text/plain X-Uptime: 06:40:39 up 56 days, 23:02, 101 users, load average: 0.16, 0.13, 0.13 User-Agent: Mutt/1.5.21 (2010-09-15) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c0 X-SA-Exim-Mail-From: sha@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1466 Lines: 34 On Thu, Aug 20, 2015 at 03:20:52PM -0700, Eduardo Valentin wrote: > On Thu, Aug 20, 2015 at 10:06:01AM +0200, Sascha Hauer wrote: > > + > > + /* > > + * These calibration values should finally be provided by the > > + * firmware or fuses. For now use default values. > > + */ > > + mt->calib_slope = -123; > > + mt->calib_offset = 465124; > > Would it make sense to use the coefficients device tree property to > describe the sensor slope and offset? > The values shall ultimately be stored in fuses in the SoC. The current bootloader cannot convert these values into device tree properties. Also there is the new nvmem framework landing. This will allow us to put a description into the device tree where in the fuses the calibration values are found, rather than putting the calibration values themselves into the device tree. This all needs some discussion and work, so I left this topic for later. Sascha -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/