Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753433AbbHUGWL (ORCPT ); Fri, 21 Aug 2015 02:22:11 -0400 Received: from aserp1040.oracle.com ([141.146.126.69]:24274 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753177AbbHUGWH (ORCPT ); Fri, 21 Aug 2015 02:22:07 -0400 From: Yinghai Lu To: Bjorn Helgaas , David Miller , Benjamin Herrenschmidt , Wei Yang , TJ , Yijing Wang Cc: Andrew Morton , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, Yinghai Lu Subject: [PATCH v4 17/52] PCI: Separate out save_resources()/restore_resources() Date: Thu, 20 Aug 2015 23:20:32 -0700 Message-Id: <1440138067-4314-18-git-send-email-yinghai@kernel.org> X-Mailer: git-send-email 1.8.4.5 In-Reply-To: <1440138067-4314-1-git-send-email-yinghai@kernel.org> References: <1440138067-4314-1-git-send-email-yinghai@kernel.org> X-Source-IP: aserv0021.oracle.com [141.146.126.233] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3239 Lines: 104 We need to save/restore resources several times for alt_size support, separate the save_resources()/resources() to save some lines later. Signed-off-by: Yinghai Lu --- drivers/pci/setup-bus.c | 49 ++++++++++++++++++++++++++++++------------------- 1 file changed, 30 insertions(+), 19 deletions(-) diff --git a/drivers/pci/setup-bus.c b/drivers/pci/setup-bus.c index ccc6f9d..4a1fb4f 100644 --- a/drivers/pci/setup-bus.c +++ b/drivers/pci/setup-bus.c @@ -430,6 +430,29 @@ static bool pci_need_to_release(unsigned long mask, struct resource *res) return false; /* should not get here */ } +static bool save_resources(struct list_head *head, + struct list_head *save_head) +{ + struct pci_dev_resource *dev_res; + + /* Save original start, end, flags etc at first */ + list_for_each_entry(dev_res, head, list) + if (add_to_list(save_head, dev_res->dev, dev_res->res)) { + free_list(save_head); + return false; + } + + return true; +} + +static void restore_resource(struct pci_dev_resource *save_res, + struct resource *res) +{ + res->start = save_res->start; + res->end = save_res->end; + res->flags = save_res->flags; +} + static void __assign_resources_sorted(struct list_head *head, struct list_head *realloc_head, struct list_head *fail_head) @@ -467,13 +490,8 @@ static void __assign_resources_sorted(struct list_head *head, if (!realloc_head || list_empty(realloc_head)) goto requested_and_reassign; - /* Save original start, end, flags etc at first */ - list_for_each_entry(dev_res, head, list) { - if (add_to_list(&save_head, dev_res->dev, dev_res->res)) { - free_list(&save_head); - goto requested_and_reassign; - } - } + if (!save_resources(head, &save_head)) + goto requested_and_reassign; /* Update res in head list with add_size in realloc_head list */ list_for_each_entry(dev_res, head, list) { @@ -542,12 +560,9 @@ static void __assign_resources_sorted(struct list_head *head, } } /* Restore start/end/flags from saved list */ - list_for_each_entry(save_res, &save_head, list) { - res = save_res->res; - res->start = save_res->start; - res->end = save_res->end; - res->flags = save_res->flags; - } + list_for_each_entry(save_res, &save_head, list) + restore_resource(save_res, save_res->res); + free_list(&save_head); requested_and_reassign: @@ -1911,9 +1926,7 @@ again: list_for_each_entry(fail_res, &fail_head, list) { struct resource *res = fail_res->res; - res->start = fail_res->start; - res->end = fail_res->end; - res->flags = fail_res->flags; + restore_resource(fail_res, res); if (fail_res->dev->subordinate) res->flags = 0; } @@ -1977,9 +1990,7 @@ again: list_for_each_entry(fail_res, &fail_head, list) { struct resource *res = fail_res->res; - res->start = fail_res->start; - res->end = fail_res->end; - res->flags = fail_res->flags; + restore_resource(fail_res, res); if (fail_res->dev->subordinate) res->flags = 0; } -- 1.8.4.5 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/