Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754147AbbHUG2e (ORCPT ); Fri, 21 Aug 2015 02:28:34 -0400 Received: from mail-wi0-f175.google.com ([209.85.212.175]:34026 "EHLO mail-wi0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753617AbbHUG2b (ORCPT ); Fri, 21 Aug 2015 02:28:31 -0400 Date: Fri, 21 Aug 2015 08:28:26 +0200 From: Ingo Molnar To: Kevin Hao Cc: Michael Ellerman , linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, Peter Zijlstra , Benjamin Herrenschmidt , Peter Zijlstra Subject: Re: [PATCH 3/8] jump_label: introduce DEFINE_STATIC_KEY_{TRUE,FALSE}_ARRAY macros Message-ID: <20150821062826.GA566@gmail.com> References: <1440072876-8321-1-git-send-email-haokexin@gmail.com> <1440072876-8321-4-git-send-email-haokexin@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1440072876-8321-4-git-send-email-haokexin@gmail.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1246 Lines: 35 * Kevin Hao wrote: > These are used to define a static_key_{true,false} array. > > Signed-off-by: Kevin Hao > --- > include/linux/jump_label.h | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/include/linux/jump_label.h b/include/linux/jump_label.h > index 7f653e8f6690..5c1d6a49dd6b 100644 > --- a/include/linux/jump_label.h > +++ b/include/linux/jump_label.h > @@ -267,6 +267,12 @@ struct static_key_false { > #define DEFINE_STATIC_KEY_FALSE(name) \ > struct static_key_false name = STATIC_KEY_FALSE_INIT > > +#define DEFINE_STATIC_KEY_TRUE_ARRAY(name, n) \ > + struct static_key_true name[n] = { [0 ... n - 1] = STATIC_KEY_TRUE_INIT } > + > +#define DEFINE_STATIC_KEY_FALSE_ARRAY(name, n) \ > + struct static_key_false name[n] = { [0 ... n - 1] = STATIC_KEY_FALSE_INIT } I think the define makes the code more obfuscated and less clear, the open-coded initialization is pretty dense and easy to read to begin with. Thanks, Ingo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/