Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753482AbbHUHo2 (ORCPT ); Fri, 21 Aug 2015 03:44:28 -0400 Received: from mga11.intel.com ([192.55.52.93]:50321 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753118AbbHUHo0 (ORCPT ); Fri, 21 Aug 2015 03:44:26 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.15,720,1432623600"; d="scan'208";a="629578075" From: "Zha, Qipeng" To: Lee Jones CC: "linux-kernel@vger.kernel.org" , "sameo@linux.intel.com" , "Yang, Fei" , "Ortiz, Samuel" Subject: RE: [PATCH v4] mfd: add Intel Broxton Whiskey Cove PMIC driver Thread-Topic: [PATCH v4] mfd: add Intel Broxton Whiskey Cove PMIC driver Thread-Index: AQHQ1Aps8B4rmojMkEOL4w48ZHge+Z4GYNiAgA+/9ZA= Date: Fri, 21 Aug 2015 07:44:21 +0000 Message-ID: References: <1439308419-130845-1-git-send-email-qipeng.zha@intel.com> <20150811150803.GN18282@x1> In-Reply-To: <20150811150803.GN18282@x1> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id t7L7iasO032281 Content-Length: 679 Lines: 15 > intel-soc-pmic-objs := intel_soc_pmic_core.o intel_soc_pmic_crc.o > +intel-soc-pmic-$(CONFIG_INTEL_PMC_IPC) += intel_soc_pmic_bxtwc.o > You want to build this for all Intel products? As intel_soc_pmic_crc driver, this is depend on the option of CONFIG_INTEL_SOC_PMIC, And it's depend on CONFIG_INTEL_PMC_IPC since hardware dependency. > + > +/* sysfs interfaces to r/w PMIC registers, required by initial script > +*/ > You really want to be able to do that from userspace? There is real requirement for this. ????{.n?+???????+%?????ݶ??w??{.n?+????{??G?????{ay?ʇڙ?,j??f???h?????????z_??(?階?ݢj"???m??????G????????????&???~???iO???z??v?^?m???? ????????I?