From: Chen Bough <Haibo.Chen@freescale.com>
To: Markus Pargmann <mpa@pengutronix.de>
CC: "robh+dt@kernel.org" <robh+dt@kernel.org>,
        "pawel.moll@arm.com" <pawel.moll@arm.com>,
        "mark.rutland@arm.com" <mark.rutland@arm.com>,
        "ijc+devicetree@hellion.org.uk" <ijc+devicetree@hellion.org.uk>,
        "galak@codeaurora.org" <galak@codeaurora.org>,
        "shawnguo@kernel.org" <shawnguo@kernel.org>,
        "kernel@pengutronix.de" <kernel@pengutronix.de>,
        "linux@arm.linux.org.uk" <linux@arm.linux.org.uk>,
        "dmitry.torokhov@gmail.com" <dmitry.torokhov@gmail.com>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        "sbranden@broadcom.com" <sbranden@broadcom.com>,
        "arnd@arndb.de" <arnd@arndb.de>,
        "mchehab@osg.samsung.com" <mchehab@osg.samsung.com>,
        "christian.gmeiner@gmail.com" <christian.gmeiner@gmail.com>,
        "scott.liu@emc.com.tw" <scott.liu@emc.com.tw>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "hdegoede@redhat.com" <hdegoede@redhat.com>,
        "jonathar@broadcom.com" <jonathar@broadcom.com>,
        "benjamin.tissoires@redhat.com" <benjamin.tissoires@redhat.com>,
        "hans.verkuil@cisco.com" <hans.verkuil@cisco.com>,
        "hadess@hadess.net" <hadess@hadess.net>,
        "linux-input@vger.kernel.org" <linux-input@vger.kernel.org>,
        "geert@linux-m68k.org" <geert@linux-m68k.org>,
        "sebastien.szymanski@armadeus.com" <sebastien.szymanski@armadeus.com>,
        "mamlinav@gmail.com" <mamlinav@gmail.com>,
        "linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>
Subject: RE: [PATCH v2 2/5] Documentation: Detail permitted DT properties for
 the imx6ul_tsc
Thread-Topic: [PATCH v2 2/5] Documentation: Detail permitted DT properties for
 the imx6ul_tsc
Thread-Index: AQHQyRugDYZbjzbCYkaq5LD/KCcxYZ4S9NQAgANKRdA=
Date: Fri, 21 Aug 2015 08:30:16 +0000
Message-ID: <BY1PR03MB1388BBEF576297D76E7E3F839A650@BY1PR03MB1388.namprd03.prod.outlook.com>
References: <1438077521-12857-1-git-send-email-haibo.chen@freescale.com>
 <1438077521-12857-3-git-send-email-haibo.chen@freescale.com>
 <20150819055434.GF11161@pengutronix.de>
In-Reply-To: <20150819055434.GF11161@pengutronix.de>
Accept-Language: zh-CN, en-US
Content-Language: en-US
spamdiagnosticoutput: 1:23
spamdiagnosticmetadata: NSPM
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Aug 2015 08:30:16.2395
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 710a03f5-10f6-4d38-9ff4-a80b81da590d
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY1PR03MB1388
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Transfer-Encoding: 8bit
X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id t7L8UWnU032506
Content-Length: 4572
Lines: 125

Hi Markus,

> -----Original Message-----
> From: Markus Pargmann [mailto:mpa@pengutronix.de]
> Sent: Wednesday, August 19, 2015 1:55 PM
> To: Chen Haibo-B51421
> Cc: robh+dt@kernel.org; pawel.moll@arm.com; mark.rutland@arm.com;
> ijc+devicetree@hellion.org.uk; galak@codeaurora.org; shawnguo@kernel.org;
> kernel@pengutronix.de; linux@arm.linux.org.uk; dmitry.torokhov@gmail.com;
> devicetree@vger.kernel.org; sbranden@broadcom.com; arnd@arndb.de;
> mchehab@osg.samsung.com; christian.gmeiner@gmail.com;
> scott.liu@emc.com.tw; linux-kernel@vger.kernel.org; hdegoede@redhat.com;
> jonathar@broadcom.com; benjamin.tissoires@redhat.com;
> hans.verkuil@cisco.com; hadess@hadess.net; linux-input@vger.kernel.org;
> geert@linux-m68k.org; sebastien.szymanski@armadeus.com;
> mamlinav@gmail.com; linux-arm-kernel@lists.infradead.org
> Subject: Re: [PATCH v2 2/5] Documentation: Detail permitted DT properties
> for the imx6ul_tsc
> 
> Hi,
> 
> On Tue, Jul 28, 2015 at 05:58:38PM +0800, Haibo Chen wrote:
> > Here we apply required documentation for the imx6ul touch screen
> > controller driver which describe available properties and how to use
> > them.
> >
> > Signed-off-by: Haibo Chen <haibo.chen@freescale.com>
> > ---
> >  .../bindings/input/touchscreen/imx6ul_tsc.txt      | 36
> ++++++++++++++++++++++
> >  1 file changed, 36 insertions(+)
> >  create mode 100644
> > Documentation/devicetree/bindings/input/touchscreen/imx6ul_tsc.txt
> >
> > diff --git
> > a/Documentation/devicetree/bindings/input/touchscreen/imx6ul_tsc.txt
> > b/Documentation/devicetree/bindings/input/touchscreen/imx6ul_tsc.txt
> > new file mode 100644
> > index 0000000..ac41c32
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/input/touchscreen/imx6ul_tsc.t
> > +++ xt
> > @@ -0,0 +1,36 @@
> > +* Freescale i.MX6UL Touch Controller
> > +
> > +Required properties:
> > +- compatible: must be "fsl,imx6ul-tsc".
> > +- reg: this touch controller address and the ADC2 address.
> 
> This suggests that this driver is using a unit ADC2. Which also means
> that there are more than one ADC which are probably identical?
> 
> Shouldn't these ADCs be properly described by their own device nodes
> instead of these two register ranges, two interrupts and two clocks?
> 
> Is 'ADC2' usable without tsc? Then ADC1/ADC2 should perhaps get a proper
> IIO driver.

For i.MX6UL, there are two ADC. ADC1 is a normal ADC, and ADC2 can only works for
TSC, the channels of ADC2 are connected to TSC directly. TSC and ADC2 should work
together as a touch screen controller. 

For ADC1, it share the driver vf610_adc.c (drivers/iio/adc/vf610_adc.c). 

Best Regards

Haibo 
 
> 
> Unfortunately I don't have the reference manual to have a look how this
> all works.
> 
> Best regards,
> 
> Markus
> 
> > +- interrupts: the interrupt of this touch controller and ADC2.
> > +- clocks: the root clock of touch controller and ADC2.
> > +- clock-names; must be "tsc" and "adc".
> > +- xnur-gpio: the X- gpio this controller connect to.
> > +  This xnur-gpio returns to high once the finger leave the touch
> > +screen (The
> > +  last touch event the touch controller capture).
> > +
> > +Optional properties:
> > +- measure-delay-time: the value of measure delay time.
> > +  Before X-axis or Y-axis measurement, the screen need some time
> > +before
> > +  even potential distribution ready.
> > +  This value depends on the touch screen.
> > +- pre-charge-time: the touch screen need some time to precharge.
> > +  This value depends on the touch screen.
> > +
> > +Example:
> > +	tsc: tsc@02040000 {
> > +		compatible = "fsl,imx6ul-tsc";
> > +		reg = <0x02040000 0x4000>, <0x0219c000 0x4000>;
> > +		interrupts = <GIC_SPI 3 IRQ_TYPE_LEVEL_HIGH>,
> > +			     <GIC_SPI 101 IRQ_TYPE_LEVEL_HIGH>;
> > +		clocks = <&clks IMX6UL_CLK_IPG>,
> > +			 <&clks IMX6UL_CLK_ADC2>;
> > +		clock-names = "tsc", "adc";
> > +		pinctrl-names = "default";
> > +		pinctrl-0 = <&pinctrl_tsc>;
> > +		xnur-gpio = <&gpio1 3 GPIO_ACTIVE_HIGH>;
> > +		measure-delay-time = <0xfff>;
> > +		pre-charge-time = <0xffff>;
> > +		status = "okay";
> > +	};
> > --
> > 1.9.1
> >
> >
> >
> 
> --
> Pengutronix e.K.                           |
> |
> Industrial Linux Solutions                 | http://www.pengutronix.de/
> |
> Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0
> |
> Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555
> |
????{.n?+???????+%?????ݶ??w??{.n?+????{??G?????{ay?ʇڙ?,j??f???h?????????z_??(?階?ݢj"???m??????G????????????&???~???iO???z??v?^?m????????????I?