Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753499AbbHUI5R (ORCPT ); Fri, 21 Aug 2015 04:57:17 -0400 Received: from mx1.redhat.com ([209.132.183.28]:58153 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752227AbbHUI5O (ORCPT ); Fri, 21 Aug 2015 04:57:14 -0400 Date: Fri, 21 Aug 2015 10:57:10 +0200 From: Jiri Olsa To: Kan Liang Cc: acme@kernel.org, a.p.zijlstra@chello.nl, luto@kernel.org, mingo@redhat.com, eranian@google.com, ak@linux.intel.com, mark.rutland@arm.com, adrian.hunter@intel.com, jolsa@kernel.org, namhyung@kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH V4 1/7] perf,tools: introduce generic FEAT for CPU attributes Message-ID: <20150821085710.GB23142@krava.brq.redhat.com> References: <1439907401-37226-1-git-send-email-kan.liang@intel.com> <1439907401-37226-2-git-send-email-kan.liang@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1439907401-37226-2-git-send-email-kan.liang@intel.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1232 Lines: 43 On Tue, Aug 18, 2015 at 10:16:35AM -0400, Kan Liang wrote: SNIP > diff --git a/tools/perf/util/header.h b/tools/perf/util/header.h > index 9b53b65..233c24d 100644 > --- a/tools/perf/util/header.h > +++ b/tools/perf/util/header.h > @@ -31,6 +31,7 @@ enum { > HEADER_PMU_MAPPINGS, > HEADER_GROUP_DESC, > HEADER_AUXTRACE, > + HEADER_CPU_ATTR, > HEADER_LAST_FEATURE, > HEADER_FEAT_BITS = 256, > }; > @@ -66,6 +67,11 @@ struct perf_header; > int perf_file_header__read(struct perf_file_header *header, > struct perf_header *ph, int fd); > > +enum perf_header_cpu_attr { > + PERF_HEADER_CPU_MAX_FREQ = 0, > + PERF_HEADER_CPU_ATTR_MAX, > +}; > + > struct perf_session_env { > char *hostname; > char *os_release; > @@ -75,6 +81,7 @@ struct perf_session_env { > int nr_cpus_avail; > char *cpu_desc; > char *cpuid; > + u64 cpu_attr[PERF_HEADER_CPU_ATTR_MAX]; it'd more readable having struct with all fields instead of the tag accesible array jirka -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/