Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753440AbbHUJAx (ORCPT ); Fri, 21 Aug 2015 05:00:53 -0400 Received: from e23smtp01.au.ibm.com ([202.81.31.143]:60831 "EHLO e23smtp01.au.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752533AbbHUJAu (ORCPT ); Fri, 21 Aug 2015 05:00:50 -0400 X-Helo: d23dlp03.au.ibm.com X-MailFrom: hegdevasant@linux.vnet.ibm.com X-RcptTo: linux-next@vger.kernel.org Message-ID: <55D6E86E.105@linux.vnet.ibm.com> Date: Fri, 21 Aug 2015 14:29:26 +0530 From: Vasant Hegde User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: Stephen Rothwell , Michael Ellerman , Benjamin Herrenschmidt , linuxppc-dev@lists.ozlabs.org CC: linux-next@vger.kernel.org, linux-kernel@vger.kernel.org, Anshuman Khandual , Stewart Smith Subject: Re: linux-next: build failure after merge of the powerpc tree References: <20150821182535.4423868e@canb.auug.org.au> In-Reply-To: <20150821182535.4423868e@canb.auug.org.au> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 15082109-1618-0000-0000-000002A599A4 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 5559 Lines: 119 On 08/21/2015 01:55 PM, Stephen Rothwell wrote: > Hi all, > > After merging the nvdimm tree, today's linux-next build (powerpc > allyesconfig) failed like this: Stephen, Thanks for reporting! I checked powerpc tree.. This is because of commit 8a8d9181 in powerpc tree.. Basically Michael missed one hunk (below hunk in opal-api.h) +/* LED Mode */ +#define POWERNV_LED_MODE_LIGHT_PATH "lightpath" +#define POWERNV_LED_MODE_GUIDING_LIGHT "guidinglight" + +/* LED type */ +#define POWERNV_LED_TYPE_IDENTIFY "identify" +#define POWERNV_LED_TYPE_FAULT "fault" +#define POWERNV_LED_TYPE_ATTENTION "attention" + +enum OpalSlotLedType { + OPAL_SLOT_LED_TYPE_ID = 0, /* IDENTIFY LED */ + OPAL_SLOT_LED_TYPE_FAULT = 1, /* FAULT LED */ + OPAL_SLOT_LED_TYPE_ATTN = 2, /* System Attention LED */ + OPAL_SLOT_LED_TYPE_MAX = 3 +}; + +enum OpalSlotLedState { + OPAL_SLOT_LED_STATE_OFF = 0, /* LED is OFF */ + OPAL_SLOT_LED_STATE_ON = 1 /* LED is ON */ +}; + @Michael, Will you be fixing it or you want me to send separate patch for this one ? -Vasant > > drivers/leds/leds-powernv.c:30:3: error: 'OPAL_SLOT_LED_TYPE_ID' undeclared here (not in a function) > {OPAL_SLOT_LED_TYPE_ID, POWERNV_LED_TYPE_IDENTIFY}, > ^ > drivers/leds/leds-powernv.c:30:27: error: 'POWERNV_LED_TYPE_IDENTIFY' undeclared here (not in a function) > {OPAL_SLOT_LED_TYPE_ID, POWERNV_LED_TYPE_IDENTIFY}, > ^ > drivers/leds/leds-powernv.c:31:3: error: 'OPAL_SLOT_LED_TYPE_FAULT' undeclared here (not in a function) > {OPAL_SLOT_LED_TYPE_FAULT, POWERNV_LED_TYPE_FAULT}, > ^ > drivers/leds/leds-powernv.c:31:29: error: 'POWERNV_LED_TYPE_FAULT' undeclared here (not in a function) > {OPAL_SLOT_LED_TYPE_FAULT, POWERNV_LED_TYPE_FAULT}, > ^ > drivers/leds/leds-powernv.c:32:3: error: 'OPAL_SLOT_LED_TYPE_ATTN' undeclared here (not in a function) > {OPAL_SLOT_LED_TYPE_ATTN, POWERNV_LED_TYPE_ATTENTION}, > ^ > drivers/leds/leds-powernv.c:32:28: error: 'POWERNV_LED_TYPE_ATTENTION' undeclared here (not in a function) > {OPAL_SLOT_LED_TYPE_ATTN, POWERNV_LED_TYPE_ATTENTION}, > ^ > drivers/leds/leds-powernv.c: In function 'powernv_led_set': > drivers/leds/leds-powernv.c:92:13: error: 'OPAL_SLOT_LED_STATE_ON' undeclared (first use in this function) > led_mask = OPAL_SLOT_LED_STATE_ON << powernv_led->led_type; > ^ > drivers/leds/leds-powernv.c:92:13: note: each undeclared identifier is reported only once for each function it appears in > drivers/leds/leds-powernv.c:92:36: error: invalid operands to binary << (have 'const struct led_type_map *' and 'int') > led_mask = OPAL_SLOT_LED_STATE_ON << powernv_led->led_type; > ^ > drivers/leds/leds-powernv.c:92:11: warning: assignment makes integer from pointer without a cast > led_mask = OPAL_SLOT_LED_STATE_ON << powernv_led->led_type; > ^ > drivers/leds/leds-powernv.c: In function 'powernv_led_get': > drivers/leds/leds-powernv.c:159:46: error: 'OPAL_SLOT_LED_STATE_ON' undeclared (first use in this function) > if (!((led_mask >> powernv_led->led_type) & OPAL_SLOT_LED_STATE_ON)) { > ^ > drivers/leds/leds-powernv.c:159:44: error: invalid operands to binary & (have 'u64' and 'const struct led_type_map *') > if (!((led_mask >> powernv_led->led_type) & OPAL_SLOT_LED_STATE_ON)) { > ^ > drivers/leds/leds-powernv.c:166:43: error: invalid operands to binary & (have 'u64' and 'const struct led_type_map *') > if ((led_value >> powernv_led->led_type) & OPAL_SLOT_LED_STATE_ON) > ^ > In file included from include/linux/byteorder/big_endian.h:4:0, > from arch/powerpc/include/uapi/asm/byteorder.h:13, > from include/asm-generic/bitops/le.h:5, > from arch/powerpc/include/asm/bitops.h:279, > from include/linux/bitops.h:36, > from include/linux/kernel.h:10, > from include/linux/list.h:8, > from include/linux/kobject.h:20, > from include/linux/device.h:17, > from include/linux/leds.h:15, > from drivers/leds/leds-powernv.c:15: > drivers/leds/leds-powernv.c: In function 'powernv_led_probe': > drivers/leds/leds-powernv.c:300:49: error: 'OPAL_SLOT_LED_TYPE_MAX' undeclared (first use in this function) > powernv_led_common->max_led_type = cpu_to_be64(OPAL_SLOT_LED_TYPE_MAX); > ^ > include/uapi/linux/byteorder/big_endian.h:36:51: note: in definition of macro '__cpu_to_be64' > #define __cpu_to_be64(x) ((__force __be64)(__u64)(x)) > ^ > drivers/leds/leds-powernv.c:300:37: note: in expansion of macro 'cpu_to_be64' > powernv_led_common->max_led_type = cpu_to_be64(OPAL_SLOT_LED_TYPE_MAX); > ^ > > Caused by commit > > 84ad6e5cd3e8 ("leds/powernv: Add driver for PowerNV platform") > > I suspect that the updates to a file were missed in the commit? > > I have reverted that commit for today. > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/