Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752785AbbHULEe (ORCPT ); Fri, 21 Aug 2015 07:04:34 -0400 Received: from aserp1040.oracle.com ([141.146.126.69]:21751 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752357AbbHULEd (ORCPT ); Fri, 21 Aug 2015 07:04:33 -0400 Date: Fri, 21 Aug 2015 14:04:55 +0300 From: Dan Carpenter To: Aparna Karuthodi Cc: gregkh@linuxfoundation.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: fbtft: Removed a space Message-ID: <20150821110455.GW5558@mwanda> References: <1440079019-9997-1-git-send-email-kdasaparna@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1440079019-9997-1-git-send-email-kdasaparna@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-Source-IP: aserv0021.oracle.com [141.146.126.233] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1318 Lines: 35 On Thu, Aug 20, 2015 at 07:26:59PM +0530, Aparna Karuthodi wrote: > Removed a space before parenthesis to remove a coding style error > detected by checkpatch. > The error is given below: > drivers/staging/fbtft/fb_bd663474.c:118: ERROR: space prohibited before > that close parenthesis ')' > > Signed-off-by: Aparna Karuthodi > --- > drivers/staging/fbtft/fb_bd663474.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/fbtft/fb_bd663474.c b/drivers/staging/fbtft/fb_bd663474.c > index 7e00c60..8619426 100644 > --- a/drivers/staging/fbtft/fb_bd663474.c > +++ b/drivers/staging/fbtft/fb_bd663474.c > @@ -115,7 +115,7 @@ static int init_display(struct fbtft_par *par) > write_reg(par, 0x100, 0x7120 ); > write_reg(par, 0x007, 0x0103 ); > mdelay( 10 ); > - write_reg(par, 0x007, 0x0113 ); > + write_reg(par, 0x007, 0x0113); Every other line in the surrounding context has the same issue. Please don't just change one line at a time like this... It is a waste of our time. regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/