From: Chao Yu <chao2.yu@samsung.com>
To: "'Jaegeuk Kim'" <jaegeuk@kernel.org>
Cc: linux-f2fs-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org
References: <017d01d0da71$5780e8d0$0682ba70$@samsung.com>
 <20150820174738.GD42028@jaegeuk-mac02.mot-mobility.com>
In-reply-to: <20150820174738.GD42028@jaegeuk-mac02.mot-mobility.com>
Subject: RE: [PATCH 9/9] f2fs: update extent tree in batches
Date: Fri, 21 Aug 2015 20:54:44 +0800
Message-id: <021801d0dc10$a4d36810$ee7a3830$@samsung.com>
MIME-version: 1.0
Content-type: text/plain; charset=us-ascii
Content-transfer-encoding: 7bit
Thread-index: AQLNlFL34fZWxqU7h2EUoA+g4rYsxAEyoVBOnBNijKA=
Content-language: zh-cn
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1168
Lines: 33

Hi Jaegeuk,

> -----Original Message-----
> From: Jaegeuk Kim [mailto:jaegeuk@kernel.org]
> Sent: Friday, August 21, 2015 1:48 AM
> To: Chao Yu
> Cc: linux-f2fs-devel@lists.sourceforge.net; linux-kernel@vger.kernel.org
> Subject: Re: [PATCH 9/9] f2fs: update extent tree in batches
> 
> Hi Chao,
> 
> On Wed, Aug 19, 2015 at 07:21:48PM +0800, Chao Yu wrote:
> > This patch introduce a new helper f2fs_update_extent_tree_range
> > which can update extent nodes in extent tree in batches.
> >
> > Now, we use the function to invalidate blocks in batches instead of
> > invalidating them one by one when truncating blocks.
> 
> IMO, it's not clear the benefit of this patch in terms of performance and code
> readability versus risky code changes.

This is only used in truncate path, IMO, in theory, we can gain benefit from
this batch mode operation when truncating frequently.

I will test the patch for numbers.

Thanks,

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/