Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753079AbbHUNOJ (ORCPT ); Fri, 21 Aug 2015 09:14:09 -0400 Received: from mail-wi0-f180.google.com ([209.85.212.180]:33589 "EHLO mail-wi0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752613AbbHUNOH (ORCPT ); Fri, 21 Aug 2015 09:14:07 -0400 Date: Fri, 21 Aug 2015 15:14:03 +0200 From: Frederic Weisbecker To: Ingo Molnar Cc: Andy Lutomirski , Andy Lutomirski , X86 ML , Sasha Levin , Brian Gerst , Denys Vlasenko , "linux-kernel@vger.kernel.org" , Oleg Nesterov , Borislav Petkov , Rik van Riel Subject: Re: [PATCH] x86/entry/64: Context-track syscalls before enabling interrupts Message-ID: <20150821131401.GA3362@lerouge> References: <20150818221623.GA12858@lerouge> <20150818230235.GA13685@lerouge> <20150819171007.GA21717@lerouge> <20150821075035.GB9511@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150821075035.GB9511@gmail.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1578 Lines: 34 On Fri, Aug 21, 2015 at 09:50:35AM +0200, Ingo Molnar wrote: > > * Frederic Weisbecker wrote: > > > > I want to have a real hook to call that says "switch to IRQ context from > > > CONTEXT_USER" or "switch to IRQ context from CONTEXT_KERNEL" (aka noop), but > > > that doesn't currently exist. > > > > You're not answering _why_ you want that. > > So we'd have a comprehensive, 100% coverage, self-sufficient set of callbacks that > track the kernel's current context state at the points where the context switches > actually occur - not just something cobbled together heterogenously. The low level > x86 asm code was rather messy in this area, better organization would be welcome, > I don't think we can overdo it. > > ( I'm assuming here that it can all be done for zero or negative cost, and that > the result will be correct and won't hurt existing users in any fashion. ) Sure, if x86 needs such a thing for internal organization it's ok, but don't do context tracking calls there. irq_enter() and irq_exit() already take care of RCU and time accounting. What Andy is doing is roughly like calling these callbacks twice for no reason. It's horrible for IRQ performances. The merge window is like tomorrow and he keeps arguing against that obvious regression instead of fixing it. Thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/