Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753797AbbHUOjw (ORCPT ); Fri, 21 Aug 2015 10:39:52 -0400 Received: from comal.ext.ti.com ([198.47.26.152]:58182 "EHLO comal.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751967AbbHUOjv (ORCPT ); Fri, 21 Aug 2015 10:39:51 -0400 Date: Fri, 21 Aug 2015 09:39:36 -0500 From: Felipe Balbi To: Kris Borer CC: , , , , , , , , , , Subject: Re: [PATCH] usb: hub: remove redundant declarations Message-ID: <20150821143936.GA527@saruman.tx.rr.com> Reply-To: References: <1440167160-8527-1-git-send-email-kborer@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="r5Pyd7+fXNt84Ff3" Content-Disposition: inline In-Reply-To: <1440167160-8527-1-git-send-email-kborer@gmail.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2570 Lines: 75 --r5Pyd7+fXNt84Ff3 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Aug 21, 2015 at 10:26:00AM -0400, Kris Borer wrote: > Fix two occurrences of the Sparse warning: >=20 > warning: symbol XXX shadows an earlier one >=20 > Signed-off-by: Kris Borer Reviewed-by: Felipe Balbi > --- > drivers/usb/core/hub.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) >=20 > diff --git a/drivers/usb/core/hub.c b/drivers/usb/core/hub.c > index 431839b..a0db6a4 100644 > --- a/drivers/usb/core/hub.c > +++ b/drivers/usb/core/hub.c > @@ -1070,7 +1070,7 @@ static void hub_activate(struct usb_hub *hub, enum = hub_activation_type type) > * for HUB_POST_RESET, but it's easier not to. > */ > if (type =3D=3D HUB_INIT) { > - unsigned delay =3D hub_power_on_good_delay(hub); > + delay =3D hub_power_on_good_delay(hub); > =20 > hub_power_on(hub, false); > INIT_DELAYED_WORK(&hub->init_work, hub_init_func2); > @@ -1404,7 +1404,6 @@ static int hub_configure(struct usb_hub *hub, > /* FIXME for USB 3.0, skip for now */ > if ((wHubCharacteristics & HUB_CHAR_COMPOUND) && > !(hub_is_superspeed(hdev))) { > - int i; > char portstr[USB_MAXCHILDREN + 1]; > =20 > for (i =3D 0; i < maxchild; i++) > --=20 > 1.9.1 >=20 --=20 balbi --r5Pyd7+fXNt84Ff3 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJV1zgnAAoJEIaOsuA1yqREkYoP/RAzu5njG+Wmex81aYTDzUTS BQBUkoCQRBI9+cXgMDDyhWKgFWzA8aLNQMLfa4kWzUCsqzJ4RnNWuaFzG61mc1pA IVNYavw7b3Fnj0TfACdV0FO3L0ko/Cz6HJz9m3ehXAbWdpSwfRjoqIwY4GxpvcmS fOUQCVzv5BDQppBTtmDJRCQBcPTxBephGzH+uiRkVHd+S3bOtqryciC2tBa9U4sP bM5MvwnW1GFngZZcpLAWHU7sqDXjaN0qU3sTOIFwRTzIas5okLIVcsCoRv5uxprC /WO/Qvub5a2mxu8Ih6wpG7WdrNaBCxj08xWGDPC7y7DVo4DI/IC8zUJKxUJn4f8V 7TAvc4WpIi6htdAIx9GO7lkQKZH4XB7yJkBnZ9fxETPJJgaVyiS1HdtI7FgeACDh 1XA7x6Zh44RDcEXCdKR7hdjzJDEqW/aNJ1UL+UC1EHpH5sX+/7xrftenjXoRMnjO oP5gOboDD01bZUT4C83qkFS5PMPbPQ6dkM6CpzejKMfA5O38I9d9bvRuM7b5vuZu kyjyhgrnhwZ7AE4B2w2SFCDgy5TUqKf+3rYto+UAqPpau3q/fQn2o69Qtb9D9TVn BPWf+y31FAfcxf6PYo4zSi4MGLOZkFlrKTuYSJR60xMgzq3oB0fA59MZJOWYqRJm 56sWWHGeFrueFI+1Gx1F =ikay -----END PGP SIGNATURE----- --r5Pyd7+fXNt84Ff3-- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/