Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751902AbbHURkB (ORCPT ); Fri, 21 Aug 2015 13:40:01 -0400 Received: from mail-ig0-f175.google.com ([209.85.213.175]:34555 "EHLO mail-ig0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751344AbbHURj7 (ORCPT ); Fri, 21 Aug 2015 13:39:59 -0400 MIME-Version: 1.0 In-Reply-To: References: <1439941188-19293-1-git-send-email-joestringer@nicira.com> <1439941188-19293-11-git-send-email-joestringer@nicira.com> Date: Fri, 21 Aug 2015 10:39:58 -0700 Message-ID: Subject: Re: [PATCHv4 net-next 10/10] openvswitch: Allow attaching helpers to ct action From: Pravin Shelar To: Joe Stringer Cc: netdev , LKML , pablo , Florian Westphal , Hannes Sowa , Thomas Graf , Justin Pettit , Jesse Gross Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1502 Lines: 33 On Thu, Aug 20, 2015 at 5:47 PM, Joe Stringer wrote: > On 19 August 2015 at 15:57, Pravin Shelar wrote: >> On Tue, Aug 18, 2015 at 4:39 PM, Joe Stringer wrote: >>> Add support for using conntrack helpers to assist protocol detection. >>> The new OVS_CT_ATTR_HELPER attribute of the ct action specifies a helper >>> to be used for this connection. >>> >>> Example ODP flows allowing FTP connections from ports 1->2: >>> in_port=1,tcp,action=ct(helper=ftp,commit),2 >>> in_port=2,tcp,ct_state=-trk,action=ct(),recirc(1) >>> recirc_id=1,in_port=2,tcp,ct_state=+trk-new+est,action=1 >>> recirc_id=1,in_port=2,tcp,ct_state=+trk+rel,action=1 >>> >>> Signed-off-by: Joe Stringer >>> --- >>> v2-v3: No change. >>> v4: Change error code for unknown helper ENOENT->EINVAL. >> >> I got following compilation warning : >> >> net/openvswitch/conntrack.c:352:42: error: incompatible types in >> comparison expression (different address spaces) > > Is this made available via another sparse flag? It looks like it's > related to the __rcu as you've mentioned below, but I'm not seeing > this (latest sparse, gcc-4.9.2) > You need to enable RCU space checker in kernel config. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/