Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752606AbbHUSSv (ORCPT ); Fri, 21 Aug 2015 14:18:51 -0400 Received: from mail-yk0-f179.google.com ([209.85.160.179]:36366 "EHLO mail-yk0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752199AbbHUSSt (ORCPT ); Fri, 21 Aug 2015 14:18:49 -0400 MIME-Version: 1.0 In-Reply-To: <1440138067-4314-44-git-send-email-yinghai@kernel.org> References: <1440138067-4314-1-git-send-email-yinghai@kernel.org> <1440138067-4314-44-git-send-email-yinghai@kernel.org> From: Rob Herring Date: Fri, 21 Aug 2015 13:18:29 -0500 Message-ID: Subject: Re: [PATCH v4 43/52] OF/PCI: Add IORESOURCE_MEM_64 for 64-bit resource To: Yinghai Lu Cc: Bjorn Helgaas , David Miller , Benjamin Herrenschmidt , Wei Yang , TJ , Yijing Wang , Andrew Morton , "linux-pci@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Grant Likely , Rob Herring , "devicetree@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1673 Lines: 48 On Fri, Aug 21, 2015 at 1:20 AM, Yinghai Lu wrote: > For device resource PREF bit setting under bridge 64-bit pref resource, > we need to make sure only set PREF for 64bit resource, so set > IORESOUCE_MEM_64 for 64bit resource during OF device resource flags > parsing. > > Link: https://bugzilla.kernel.org/show_bug.cgi?id=96261 > Link: https://bugzilla.kernel.org/show_bug.cgi?id=96241 > Signed-off-by: Yinghai Lu > Cc: Grant Likely > Cc: Rob Herring > Cc: devicetree@vger.kernel.org My comment from v1[1] is not addressed still. Rob [1] https://lkml.org/lkml/2015/7/10/736 > --- > drivers/of/address.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/of/address.c b/drivers/of/address.c > index 8bfda6a..073125f 100644 > --- a/drivers/of/address.c > +++ b/drivers/of/address.c > @@ -128,9 +128,11 @@ static unsigned int of_bus_pci_get_flags(const __be32 *addr) > flags |= IORESOURCE_IO; > break; > case 0x02: /* 32 bits */ > - case 0x03: /* 64 bits */ > flags |= IORESOURCE_MEM; > break; > + case 0x03: /* 64 bits */ > + flags |= IORESOURCE_MEM | IORESOURCE_MEM_64; > + break; > } > if (w & 0x40000000) > flags |= IORESOURCE_PREFETCH; > -- > 1.8.4.5 > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/