Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752876AbbHUSXB (ORCPT ); Fri, 21 Aug 2015 14:23:01 -0400 Received: from mail-pa0-f43.google.com ([209.85.220.43]:33624 "EHLO mail-pa0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751751AbbHUSW7 (ORCPT ); Fri, 21 Aug 2015 14:22:59 -0400 MIME-Version: 1.0 X-Originating-IP: [67.161.9.61] In-Reply-To: <1440179024-22374-1-git-send-email-jcmvbkbc@gmail.com> References: <1440179024-22374-1-git-send-email-jcmvbkbc@gmail.com> Date: Fri, 21 Aug 2015 11:22:59 -0700 Message-ID: Subject: Re: [PATCH v3] xtensa: improve vmlinux.lds.S sed post-processing From: Chris Zankel To: Max Filippov Cc: "linux-xtensa@linux-xtensa.org" , Marc Gauthier , Guenter Roeck , LKML Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2354 Lines: 55 Thanks Max. Running a test build and will add to xtensa-next. On Fri, Aug 21, 2015 at 10:43 AM, Max Filippov wrote: > Current sed script makes assumptions about the structure of rules that > group .text sections in the vmlinux linker script. These assumptions > get broken occasionally, e.g.: 779c88c94c34 "ARM: 8321/1: asm-generic: > introduce.text.fixup input section", or 9bebe9e5b0f3 "kbuild: Fix > .text.unlikely placement". > > Rewrite sed rules so that they don't depend on number/arrangement of text > sections in *(...) blocks. > > Signed-off-by: Max Filippov > --- > This fixes breakage in the linux-next. Chris, could you please apply it to > your for_next branch? > > Changes v2 -> v3: > - rebase to the current master > > Changes v1 -> v2: > - don't change arbitrary sections containing .text, only .text, .ref.text > and .[a-z]*it.text > > arch/xtensa/kernel/Makefile | 9 +++++---- > 1 file changed, 5 insertions(+), 4 deletions(-) > > diff --git a/arch/xtensa/kernel/Makefile b/arch/xtensa/kernel/Makefile > index d3a0f0f..ad93217 100644 > --- a/arch/xtensa/kernel/Makefile > +++ b/arch/xtensa/kernel/Makefile > @@ -27,10 +27,11 @@ AFLAGS_head.o += -mtext-section-literals > # > # Replicate rules in scripts/Makefile.build > > -sed-y = -e 's/\*(\(\.[a-z]*it\|\.ref\|\)\.text)/*(\1.literal \1.text)/g' \ > - -e 's/\.text\.unlikely/.literal.unlikely .text.unlikely/g' \ > - -e 's/\*(\(\.text .*\))/*(.literal \1)/g' \ > - -e 's/\*(\(\.text\.[a-z]*\))/*(\1.literal \1)/g' > +sed-y = -e ':a; s/\*(\([^)]*\)\.text\.unlikely/*(\1.literal.unlikely .{text}.unlikely/; ta; ' \ > + -e ':b; s/\*(\([^)]*\)\.text\(\.[a-z]*\)/*(\1.{text}\2.literal .{text}\2/; tb; ' \ > + -e ':c; s/\*(\([^)]*\)\(\.[a-z]*it\|\.ref\)\.text/*(\1\2.literal \2.{text}/; tc; ' \ > + -e ':d; s/\*(\([^)]\+ \|\)\.text/*(\1.literal .{text}/; td; ' \ > + -e 's/\.{text}/.text/g' > > quiet_cmd__cpp_lds_S = LDS $@ > cmd__cpp_lds_S = $(CPP) $(cpp_flags) -P -C -Uxtensa -D__ASSEMBLY__ $< \ > -- > 1.8.1.4 > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/