Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752915AbbHUSYI (ORCPT ); Fri, 21 Aug 2015 14:24:08 -0400 Received: from mail-io0-f181.google.com ([209.85.223.181]:33879 "EHLO mail-io0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751730AbbHUSYG (ORCPT ); Fri, 21 Aug 2015 14:24:06 -0400 MIME-Version: 1.0 In-Reply-To: References: <1440138067-4314-1-git-send-email-yinghai@kernel.org> <1440138067-4314-44-git-send-email-yinghai@kernel.org> Date: Fri, 21 Aug 2015 11:24:04 -0700 X-Google-Sender-Auth: i9rBtz_5qojcNUoLDZen5TnP0TE Message-ID: Subject: Re: [PATCH v4 43/52] OF/PCI: Add IORESOURCE_MEM_64 for 64-bit resource From: Yinghai Lu To: Rob Herring Cc: Bjorn Helgaas , David Miller , Benjamin Herrenschmidt , Wei Yang , TJ , Yijing Wang , Andrew Morton , "linux-pci@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Grant Likely , Rob Herring , "devicetree@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1334 Lines: 33 On Fri, Aug 21, 2015 at 11:18 AM, Rob Herring wrote: > On Fri, Aug 21, 2015 at 1:20 AM, Yinghai Lu wrote: >> For device resource PREF bit setting under bridge 64-bit pref resource, >> we need to make sure only set PREF for 64bit resource, so set >> IORESOUCE_MEM_64 for 64bit resource during OF device resource flags >> parsing. >> >> Link: https://bugzilla.kernel.org/show_bug.cgi?id=96261 >> Link: https://bugzilla.kernel.org/show_bug.cgi?id=96241 >> Signed-off-by: Yinghai Lu >> Cc: Grant Likely >> Cc: Rob Herring >> Cc: devicetree@vger.kernel.org > > My comment from v1[1] is not addressed still. > > > [1] https://lkml.org/lkml/2015/7/10/736 | As the BZ says, we have several identical functions. Can we fix the | drivers/of/address.c version and remove the Sparc versions. The only | diff is the generic version converts from be32. I think that should be | a nop for Sparc. That would be better to let guys with Sparc or other OF arch to do the unification. Yinghai -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/