Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752975AbbHUUZb (ORCPT ); Fri, 21 Aug 2015 16:25:31 -0400 Received: from mga01.intel.com ([192.55.52.88]:34464 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752224AbbHUUZa convert rfc822-to-8bit (ORCPT ); Fri, 21 Aug 2015 16:25:30 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.15,723,1432623600"; d="scan'208";a="753095214" From: "Liang, Kan" To: Jiri Olsa CC: "acme@kernel.org" , "a.p.zijlstra@chello.nl" , "mingo@redhat.com" , "jolsa@kernel.org" , "namhyung@kernel.org" , "ak@linux.intel.com" , "eranian@google.com" , "linux-kernel@vger.kernel.org" Subject: RE: [PATCH RFC 02/10] perf,tools: Support new sort type --socket Thread-Topic: [PATCH RFC 02/10] perf,tools: Support new sort type --socket Thread-Index: AQHQ2dS6vE9WDKEZU0eaXfJMfAX6MJ4UFf2AgALIVIA= Date: Fri, 21 Aug 2015 20:25:24 +0000 Message-ID: <37D7C6CF3E00A74B8858931C1DB2F077018F1D04@SHSMSX103.ccr.corp.intel.com> References: <1439889946-28986-1-git-send-email-kan.liang@intel.com> <1439889946-28986-3-git-send-email-kan.liang@intel.com> <20150820090913.GB1672@krava.brq.redhat.com> In-Reply-To: <20150820090913.GB1672@krava.brq.redhat.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2584 Lines: 98 > On Tue, Aug 18, 2015 at 05:25:38AM -0400, kan.liang@intel.com wrote: > > From: Kan Liang > > > > This patch enable perf report to sort by socket > > > > SNIP > > > diff --git a/tools/perf/util/sort.c b/tools/perf/util/sort.c index > > 7e38716..245e254 100644 > > --- a/tools/perf/util/sort.c > > +++ b/tools/perf/util/sort.c > > @@ -421,6 +421,33 @@ struct sort_entry sort_cpu = { > > .se_width_idx = HISTC_CPU, > > }; > > > > +/* --sort socket */ > > + > > +static int64_t > > +sort__socket_cmp(struct hist_entry *left, struct hist_entry *right) { > > + int r_socket, l_socket; > > + > > + r_socket = cpu__get_socket(right->cpu); > > + l_socket = cpu__get_socket(left->cpu); > > + return r_socket - l_socket; > > we need global topology information in perf.data and use the mapping > from there, we can't use current server info > > we currently store core_siblings_list and thread_siblings_list, in topology > FEATURE, which is probably not enough > core_siblings_list includes the cpu list in the same socket. thread_siblings_list includes the cpu list in the same core. numa_nodes includes the cpu list for each node. It looks we have enough data from topology FEATURE. What do you think about the function as below? It gets the socket id from env. +int +perf_env_get_socket(struct perf_session_env *env, int cpu) +{ + int socket_nr, cpu_nr, i, j; + struct cpu_map *socket_map = NULL; + char *str; + + if (env == NULL) + return -1; + + socket_nr = env->nr_sibling_cores; + str = env->sibling_cores; + + for (i = 0; i < socket_nr; i++) { + socket_map = cpu_map__new(str); + str += strlen(str) + 1; + if (!socket_map) + continue; + cpu_nr = socket_map->nr; + for (j = 0; j < cpu_nr; j++) { + if (cpu == socket_map->map[j]) { + free(socket_map); + return i; + } + } + free(socket_map); + } + + return -1; +} Thanks, Kan > I think we need new feature that stores topology info and new interface > that will provide all useful mappings: > idx -> cpu > cpu -> core > cpu -> socket > cpu -> node > > in another patchset I used new CPUMAP event: > https://git.kernel.org/cgit/linux/kernel/git/jolsa/perf.git/commit/?h=perf/ > stat_script_3&id=37b7b8449aa23acdfe9dec5a7a371e91c5323da5 > > we might need both ways (new FEATURE and event) to support pipe > reports > > jirka -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/