Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753219AbbHUWUD (ORCPT ); Fri, 21 Aug 2015 18:20:03 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:38043 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751175AbbHUWT7 (ORCPT ); Fri, 21 Aug 2015 18:19:59 -0400 Message-ID: <46812b2d9fe024d935063d634e9e8971.squirrel@www.codeaurora.org> In-Reply-To: References: <1440079144-26461-1-git-send-email-ygardi@codeaurora.org> <1440079144-26461-7-git-send-email-ygardi@codeaurora.org> Date: Fri, 21 Aug 2015 22:19:58 -0000 Subject: Re: [PATCH v2 6/8] scsi: ufs: make the UFS variant a platform device From: ygardi@codeaurora.org To: "Akinobu Mita" Cc: "Yaniv Gardi" , "Rob Herring" , "Jej B" , "Paul Bolle" , "Christoph Hellwig" , "LKML" , "linux-scsi@vger.kernel.org" , linux-arm-msm@vger.kernel.org, "Santosh Y" , linux-scsi-owner@vger.kernel.org, "Subhash Jadavani" , "Gilad Broner" , "Dolev Raviv" , "Vinayak Holikatti" , "James E.J. Bottomley" User-Agent: SquirrelMail/1.4.22-4.el6 MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7BIT X-Priority: 3 (Normal) Importance: Normal Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1991 Lines: 54 > 2015-08-20 22:59 GMT+09:00 Yaniv Gardi : >> @@ -1036,7 +1037,7 @@ void ufs_qcom_clk_scale_notify(struct ufs_hba >> *hba) >> * The variant operations configure the necessary controller and PHY >> * handshake during initialization. >> */ >> -static const struct ufs_hba_variant_ops ufs_hba_qcom_vops = { >> +static struct ufs_hba_variant_ops ufs_hba_qcom_vops = { > > It's better to keep const. In order to do this, we also need to put > const to 'vops' member in struct ufs_hba and the second argument of > ufshcd_pltfrm_init(). Why do you think it would be better to keep the vops as a const and have the vops member in struct ufs_hba be const ? I would say it is better to have the vops as is, and let each variany decidehow it should behave. > >> +static void ufs_qcom_shutdown(struct platform_device *pdev) >> +{ >> + ufshcd_shutdown((struct ufs_hba *)platform_get_drvdata(pdev)); >> +} > > We don't need this function anymore since we have > ufshcd_pltfrm_shutdown() now. ok, as this variant shutdown is doing the same as pltform shutdown' it can go away. > >> -static void ufshcd_pltfrm_shutdown(struct platform_device *pdev) >> +void ufshcd_pltfrm_shutdown(struct platform_device *pdev) >> { >> - ufshcd_shutdown((struct ufs_hba *)platform_get_drvdata(pdev)); >> + ufshcd_shutdown((struct ufs_hba *)platform_get_drvdata(pdev)); > > Whitespace is used as code indent. There are same issues in > this patch series, so I recommend running checkpatch.pl before > sending patches. > -- > To unsubscribe from this list: send the line "unsubscribe linux-scsi" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/