Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752990AbbHVC4S (ORCPT ); Fri, 21 Aug 2015 22:56:18 -0400 Received: from mail-vk0-f46.google.com ([209.85.213.46]:33287 "EHLO mail-vk0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752261AbbHVC4Q (ORCPT ); Fri, 21 Aug 2015 22:56:16 -0400 MIME-Version: 1.0 In-Reply-To: <545cd2cdf947a2a59f5d021c27bdc78f.squirrel@www.codeaurora.org> References: <1440079144-26461-1-git-send-email-ygardi@codeaurora.org> <1440079144-26461-8-git-send-email-ygardi@codeaurora.org> <545cd2cdf947a2a59f5d021c27bdc78f.squirrel@www.codeaurora.org> Date: Sat, 22 Aug 2015 11:56:14 +0900 Message-ID: Subject: Re: [PATCH v2 7/8] scsi: ufs-qcom: add debug prints for test bus From: Akinobu Mita To: Yaniv Gardi Cc: Rob Herring , Jej B , Paul Bolle , Christoph Hellwig , LKML , "linux-scsi@vger.kernel.org" , linux-arm-msm@vger.kernel.org, Santosh Y , linux-scsi-owner@vger.kernel.org, Subhash Jadavani , Gilad Broner , Dolev Raviv , Vinayak Holikatti , "James E.J. Bottomley" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1461 Lines: 32 2015-08-22 7:23 GMT+09:00 : >> 2015-08-20 22:59 GMT+09:00 Yaniv Gardi : >>> @@ -30,6 +48,14 @@ static void ufs_qcom_get_speed_mode(struct >>> ufs_pa_layer_attr *p, char *result); >>> static int ufs_qcom_get_bus_vote(struct ufs_qcom_host *host, >>> const char *speed_mode); >>> static int ufs_qcom_set_bus_vote(struct ufs_qcom_host *host, int vote); >>> +static void ufs_qcom_get_default_testbus_cfg(struct ufs_qcom_host >>> *host); >>> +static void ufs_qcom_dump_regs(struct ufs_hba *hba, int offset, int >>> len, >>> + char *prefix) >>> +{ >>> + print_hex_dump(KERN_ERR, prefix, >>> + len > 4 ? DUMP_PREFIX_OFFSET : DUMP_PREFIX_NONE, >>> + 16, 4, hba->mmio_base + offset, len * 4, false); >>> +} >> >> This causes a sparse warning as __iomem pointer is passed to >> print_hex_dump(). > > indeed. > any suggestions how it can be fixed ? I guess I shall try casting. I think introducing generic print_hex_dump_io() library function is useful for this and other drivers want to use it. But for now we can just create simple local dump function which readl() and print for each register. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/