Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753403AbbHVHxG (ORCPT ); Sat, 22 Aug 2015 03:53:06 -0400 Received: from m12-11.163.com ([220.181.12.11]:59564 "EHLO m12-11.163.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751870AbbHVHxE (ORCPT ); Sat, 22 Aug 2015 03:53:04 -0400 From: Yaowei Bai To: akpm@linux-foundation.org, mgorman@suse.de, vbabka@suse.cz, mhocko@suse.com, js1304@gmail.com, hannes@cmpxchg.org, alexander.h.duyck@redhat.com, sasha.levin@oracle.com Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: [PATCH 1/3] mm/page_alloc: fix a terrible misleading comment Date: Sat, 22 Aug 2015 15:40:10 +0800 Message-Id: <1440229212-8737-1-git-send-email-bywxiaobai@163.com> X-Mailer: git-send-email 1.9.1 X-CM-TRANSID: C8CowEB5LkLWJ9hV9KBhAQ--.88S3 X-Coremail-Antispam: 1Uf129KBjvdXoW7Jr45JF4kZr1rWF4fJFWrKrg_yoWDurb_W3 WUJwsak34UtryUKF4UtayfGw4xK3s5CFWkGw1rJF13ta48Xas5XrykXry3Zrs7W3y8WrZx uwn0yFZxt34a9jkaLaAFLSUrUUUUUb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUvcSsGvfC2KfnxnUUI43ZEXa7IU5eGQ3UUUUU== X-Originating-IP: [121.238.252.42] X-CM-SenderInfo: xe1z5x5dretxi6rwjhhfrp/1tbiKx1eT1QG8tYXAwAAsF Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1285 Lines: 31 The comment says that the per-cpu batchsize and zone watermarks are determined by present_pages which is definitely wrong, they are both calculated from managed_pages. Fix it. Signed-off-by: Yaowei Bai --- mm/page_alloc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mm/page_alloc.c b/mm/page_alloc.c index 5b5240b..c22b133 100644 --- a/mm/page_alloc.c +++ b/mm/page_alloc.c @@ -6003,7 +6003,7 @@ void __init mem_init_print_info(const char *str) * set_dma_reserve - set the specified number of pages reserved in the first zone * @new_dma_reserve: The number of pages to mark reserved * - * The per-cpu batchsize and zone watermarks are determined by present_pages. + * The per-cpu batchsize and zone watermarks are determined by managed_pages. * In the DMA zone, a significant percentage may be consumed by kernel image * and other unfreeable allocations which can skew the watermarks badly. This * function may optionally be used to account for unfreeable pages in the -- 1.9.1 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/